jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
419 stars 128 forks source link

Jellyfin Roku does not respect aspect ratio metadata #1395

Open dathbe opened 10 months ago

dathbe commented 10 months ago

Software Versions

Describe the bug

When aspect ratio information is added to the metadata of a file, Jellyfin server webplayer and the Jellyfin iOS app respect the tag and stretches the image. Jellyfin Roku does not.

How To Reproduce

  1. Change the aspect ratio of a video file with ffmpeg: ffmpeg -i input.mkv -aspect 221:100 -c copy output.mkv This results in a video with characteristics like the following: Stream #0:0: Video: hevc (Main 10), yuv420p10le(tv, bt709), 1920x922 [SAR 1:1 DAR 960:461], SAR 52:49 DAR 49920:22589, 23.98 fps, 23.98 tbr, 1k tbn, 23.98 tbc (default)
  2. Play the file.
  3. Bug occurs

Expected behavior

The player should respect the aspect ratio tag.

Logs

N/A, though I'm happy to post something if requested.

Screenshots

I can provide these if interested, but it won't be particularly interesting.

Connection Information

Additional context

Happy to answer any questions.

Tech180 commented 7 months ago

I also seem to be having this problem. It happens only when using direct play and actually affects most of the movies in my library (due to direct play av1). I'm unsure if this was because i chose to select use upscaling in handbrake when transcoding them in the first place. However, I only experience this bug within the Jellyfin Roku app and not within the web browser, Android TV version, the linux Jellyfin Desktop app, the Windows Jellyfin Desktop app, the Android jellyfin app, or the Android Findroid app.

On version 2.0.0

lakerssuperman commented 1 week ago

So I'm not totally sure about the why and how of it yet, but I was attempting to encode my X-Files DVD's in AV1 the other day and no matter what I did, the Roku Jellyfin app would only play the video back in 3:2 aspect even though I set the aspect flag in the mkv container to 4:3. My older encodes of these DVD's playback with the correct aspect ratio so I'm not sure if it's an AV1 thing yet or not. My Bluray rips/encodes playback with the correct aspect ratio so I'm not sure yet exactly where the problem creeps in. I'm guessing AV1 and DVD aren't playing nice for some reason.

I should also mention that these files play back in the correct aspect ratio everywhere else (phone, web browser, desktop video player).