search

jellyfin / jellyfin-roku

The Official Roku Client for Jellyfin
https://jellyfin.org
GNU General Public License v2.0
450 stars 141 forks source link

subtitles added successfully but are not visible while playing #358

Closed cpankonien closed 3 years ago

cpankonien commented 3 years ago

subtitles added but are not visible.

subtitles were added using the Open Subtitles plugin, but I have also manualy copied the .srt file to the same dir as the video file and named it exactly the same as the .mkv except with .srt file extension.

OS: Ubuntu 20.04.1 Virtualization: none Clients: roku, browser Browser: latest Chrome Jellyfin Version: 10.7rc2 Playback: all Installed Plugins: AudioDB, MusicBrainz, OMDb, Open Subtitles Reverse Proxy: none Base URL: none Networking: n/a Storage: local

To Reproduce

start episode click asterisk, set options "Captions mode: on always" and "Caption track: 1 of 1 (English) during play, hit down arrow, select subtitle track "English" Expected behavior - subtitles play So...subtitles added successfully and selected successfully but do not work. Subtitles do work in web player.

Logs none

Screenshots n/a Additional context I have verified that the .srt file is in the location indicated, and contains subtitle text.

Subtitles work correctly in web viewer but not on roku

neilsb commented 3 years ago

Do they fail on all Media via the Roku, or just some? Can you also let me know if they are shown when using the web player, for titles that fail on the Roku?

Drose221193 commented 3 years ago

I can confirm I am having the same issue. I have had the Roku subtitles work in the past, but it was fairly inconsistent. I saw this issue so decided to test various movies and shows. All media seems to not be displaying any subtitles. The media I tested works on the web player as well as Android tv. I have subtitle settings set to always play so they are automatically selected when I play media. I also tried toggling the subtitles off and on while the media was playing and that did not work.

rystaf commented 3 years ago

Same thing happened to me after upgrading jellyfin to 10.7.0. Was working fine before. Unsure what version I was on before the upgrade (docker latest tag strikes again). Subtitles work on Intune on AppleTV and in the web player. No subtitle for any media on roku (captions on always, down arrow english). tried the channel from the store as well as the dev version from github.

crass commented 3 years ago

I believe I'm having the same issue on Jellyfin 10.7.1 (docker image) with my Roku Streaming stick. I've tried both the main and beta channels. I am testing with an mkv which has two SRT subtitle files one for english and one for spanish. I have them named properly in the same directory as the mkv. Also the subtitle files are encoded as tracks in the mkv. So there are a total of 4 SRT subtitle tracks recognized (2 in the file and 2 outside). The web client detects and displays all 4 subtitle files. The roku detects the 4 "caption tracks", however none are displayed when selected when the "captions mode" is set to "On always".

I don't see any obvious issues in the Jellyfish server logs. Is there a way to get debug logs from a roku devices? Or something I can do to help debug this issue?

neilsb commented 3 years ago

@crass I believe #385 will resolve this issue, but external verification will be useful.

In the 10.7 release there was a change to the API that caused sub titles (certainly .srt) to no longer work. An issue was raised on server to re-introduce backward compatibility and has been closed, so the next point release of 10.7 should also fix this problem.

We've currently got a release in the approval pipeline with Roku, but it's taking longer than usual. But whichever happens first (next 10.7 release or Roku approval) should mean the issue is hopefully closed.

crass commented 3 years ago

Hmm, am I incorrect in thinking the JellyfinBeta channel is the what will be the new Roku release? In other words, shouldn't subtitles be working in the beta channel?

neilsb commented 3 years ago

Up to now we haven't consistently done beta releases prior to releasing to the live channel. This a process I think we're going to try and follow more closely however.

That said, we published a Beta update a few days ago, but for some reason the Beta channel is not updating on clients. It's currently an old version you're getting via the beta link (1.3.5 - earlier than the live version). Hopefully we'll get to the bottom of this shortly.

neilsb commented 3 years ago

@crass That is the Beta version issue resolved, and should contain the Subtitle fix. Would appreciate it if you let us know if it resolves it for you when you get a chance.

crass commented 3 years ago

Just tested and it does indeed work. Thanks for the hard work!

rangerxusa commented 3 years ago

Been trying out Plex last couple weeks. Decided to also try out JellyFin as well. JellyFin is very nice open source alternative. Only show stopper so far was no external .srt subtitles on Roku devices.

Subscribed to Roku JellyFinBeta channel. Subtitles are working fine now.

Thanks!

neilsb commented 3 years ago

Note Server v10.7.2 has now been released, that should resolve the text subtitle issue with the current live client. We are still waiting for approval for the Roku Channel Store the the updated client.

neilsb commented 3 years ago

The 10.4.7 release available in to store should resolve the srt subtitles issue. Burn in subtitles (covered in other open issues) are scheduled to be resolved in the next release probably around the start of May.