jellyfin / jellyfin-webos

WebOS Client for Jellyfin
https://jellyfin.org
Mozilla Public License 2.0
638 stars 66 forks source link

Publish to store #28

Closed FrostByte2 closed 2 years ago

FrostByte2 commented 4 years ago

0.2.2 i have already made a ipk attatched in case dont want to make one.

it is inside the zip org.jellyfin.webos_0.2.2_all.zip

anthonylavado commented 4 years ago

@ghostrobo282 Please don't do this. You would be intentionally holding back our progress.

Tyri0n commented 4 years ago

I can see where he's coming from - having Jellyfin disappear from TV if you forget to periodically extend develop mode session is pretty irritating.

anthonylavado commented 4 years ago

@Tyri0n I understand, but trying to do things like this, even threatening to do so, has several effects:

A lot of people don't know the work that has to be put in behind the scenes to get something published, tested, and accepted for app stores and vendor requirements. I put in several hours of work for each place we offer our apps. I can safely say the TV app stores are by far the most restrictive, requiring the most work of all to go through stacks of agreements, documents, many e-mail messages, and more. I'd rather get a root canal in some cases. Publishing on the Apple App Store is a cakewalk by comparison.

We don't immediately submit the apps because these places have stringent requirements (as they should) to ensure that an app works the way a user expects it to when they download it to their TV. There's years worth of compatibility to optimize for, and that's still a work in progress in the main web repo (which is what this serves).

I want the many hours of work that our contributors have done (for free and in their spare time!) to be respected properly, not dismissed because anyone can't wait for it to be just right.

This issue opener even noted in another comment of theirs (and in a YouTube video they posted) that it doesn't work correctly in all cases.

Tyri0n commented 4 years ago

@anthonylavado Fair enough and thanks for your efforts. Any idea on when it's likely to be available on the app store?

anthonylavado commented 4 years ago

@Tyri0n For that, I will defer to our contributors: https://forum.jellyfin.org/t/jellyfin-for-lg-webos/236/23?u=anthonylavado

A large portion of the app will only really work with 10.6, so it will have to be at least after that gets released.

Tyri0n commented 4 years ago

@anthonylavado Lovely, thanks. Will keep a keen eye on that thread. Keep up the good work!

FrostByte2 commented 4 years ago

I hope to see more progress soon thanks for the update on the app I have noticed the bug with the tv shows tab mine on my TV puts the words tvshow on top of the shows tab on top anyone else having this issue or know how to fix it would be greatly appreciated hope to see the project expand

Rohaq commented 4 years ago

@anthonylavado Is there a tracked checklist for what needs to be done to get the app into a good enough state for publishing?

It might encourage more contributions if people had a list of requirements to burn through if they're motivated enough to get this on the store! 🙂

heyhippari commented 4 years ago

@Rohaq The big thing is going through this document, checking everything, and fixing what doesn't pass LG's QA requirements.

Pretty much all of the fixes will happen on https://github.com/jellyfin/jellyfin-web/ and not here, though.

edrevo commented 4 years ago

I am getting "Invalid File" with the link provided by @MrTimscampi. Do I need to login somewhere to be able to see the file or is the link invalid?

dkanada commented 4 years ago

It turns out you do need to login for the link to work.

FrostByte2 commented 4 years ago

There is a link to my video

surdu commented 4 years ago

It turns out you do need to login for the link to work.

Login where? There is no login link / box.

@anthonylavado Other than going through that checklist, is there anything else that the community can help with to make this happen? Hacktoberfest is coming, and might be a nice idea to mark with the "hacktoberfest" label some issues that can push this publishing along.

PS: it might also be a good idea to break those checkpoints from the LG document into GitHub issues, so it would be easier to follow and fix.

anthonylavado commented 4 years ago

@surdu That is a good idea. If I'm not mistaken though, a lot of the work has to take place in https://github.com/jellyfin/jellyfin-web, which is undergoing a big change.

surdu commented 4 years ago

@anthonylavado Then in addition to the "hacktoberfest" label, the issues that help publishing the app on WebOS could be labeled as such in the jellyfin-web project.

Brice187 commented 3 years ago

Any ETA fir this one? Or is it possible to extend developer mode for more than 50h?

Rohaq commented 3 years ago

Any ETA fir this one? Or is it possible to extend developer mode for more than 50h?

The 50 hour limit in developer mode is a restriction on the LG itself - there's nothing the app can do to get around it, aside from being officially published on the LG Store.

oddstr13 commented 3 years ago

Looks like the mentioned checklist download isn't hot-linkable. Clicking the documents_for_app_qa.zip link on this page works; http://webostv.developer.lge.com/design/ux-checklist/

cj2tech commented 3 years ago

Any update on this or eta? Legit been waiting forever for this. Been the last price for me before I can't fully switch over to jellyfin lol.

Brice187 commented 3 years ago

Would love to see a list of tasks which should be done to get the app published in the LG store. Maybe I could work on some of those tasks.

The app is published on other major platforms like AndroidTV and FireTV. I think the QA requirements are nearly the same for webOS...

heyhippari commented 3 years ago

The app is published on other major platforms like AndroidTV and FireTV

These are a completely different app, made specifically for Android. This one essentially runs the web client.

The best way to help get this published would be to go over LG's QA checklist and fix the items that don't meet their requirements. The checklist is linked above in @oddstr13 's post.

Brice187 commented 3 years ago

Okay, so here are the needed documents for LG appstore submission:

I will be working on some of the items, contributions are welcome. When all points are filled, i will hand it over to the project maintainers and hope they will submit the app soon :)

Brice187 commented 3 years ago

Filled out pretty much of the forms, but I would love to have some jellyfin internal QA :-). Especially some "developer comments" would be nice

Who is in charge for submitting the app to the store? Some tasks can not be prefilled, because they have to be done on the fly.

Brice187 commented 3 years ago

@anthonylavado hey, i filled out the needed forms:

self evaluation

self_evaluation_checklist_4.0_jellyfin.xlsx

Please take a closer look at items 1, 3, 49

ux scenario

ux_scenario_document_4.3_jellyfin.pptx

Would be great to get some feedback. Please tell me if you need more information. Maybe we can get jellyfin submitted to the LG store in this year :)

anthonylavado commented 3 years ago

I'll go over this. Thanks!

Brice187 commented 3 years ago

Hey @anthonylavado,

Did you get the time to take a closer look ? :)

EraYaN commented 3 years ago

@Brice187 The pttx should only contain licensed media in screenshots, so we'll have to use the demo server for screenshots (and probably the login bit as well) Other than that I really like it and I hope LG likes it to. I hope that main flow in enough for them and they don't need to see every option, cause then we need to go and hide the dashboard on LG TVs.

Will host progress here: https://1drv.ms/u/s!Ap7S9bwRtZkgh_hnIpzHx5eFgYKUsw?e=IAh2H8

heyhippari commented 3 years ago

cause then we need to go and hide the dashboard on LG TVs.

That's done in 10.7 already :wink:

Brice187 commented 3 years ago

@EraYaN Removed licensed media and used public domain / Creative Commons Attribution 3.0 (https://peach.blender.org/about/) media.

I do not have a 1drv account, so i uploaded the file here: ux_scenario_document_4.3_jellyfin.pptx

EraYaN commented 3 years ago

Thank you for the changes, I have updated the hosted document.

Nickbert7 commented 3 years ago

Is there any uptate on getting the app published to the store?

mastha7 commented 3 years ago

Hi,

@anthonylavado @EraYaN any updates? How we can help?

dkanada commented 3 years ago

I'm not sure on the current status, but right now I think the team is waiting on 10.8.0 for some better support for older browsers. I can't say exactly since I'm not involved in the WebOS client, but I'm not aware of any blockers. Maybe the experience on 10.7.0 is good enough for a release.

XanderStrike commented 3 years ago

10.7.0 is absolutely good enough for release. The only issue I have with it is having to reinstall every 50 hours. I wonder if we can get @anthonylavado to weigh in since they're the one who initially wanted to hold it back?

anthonylavado commented 3 years ago

@XanderStrike I wasn't deliberately holding anything back, I was waiting for the web team to tell me "Okay, this is good to go now". My understanding is that this is the case with 10.7, so we have already been preparing on the backend for it.

dovecode commented 3 years ago

I just found this thread. Is there anything a non-WebOS developer can do to help progress this (review docs, test builds, etc), or should I take @anthonylavado's message abovce to mean that it is all done and just a matter of time?

da-anda commented 3 years ago

I used 10.7 webinterface version on my LG and it works good enough, even purely via the browser on the TV. The only annoyance is that it won't stay fullscreen when you hit back on the remote. So looking forward to the app.

Brice187 commented 3 years ago

Thank you for keeping us updated 😎

supersebbo commented 3 years ago

@anthonylavado Extrapolating from your comments on Jan 2, is the WebOS app going to get published in the LG store along side the JF 10.7 release? If not - repeat the ask if there is anything the community can do to help? Has the submission been review by LG yet and is there any specific feedback that needs action? Thanks!

bronson commented 3 years ago

Just installed it and yall are right: the web interface works great. Much better than I'd expect. I almost don't believe my eyes and ears. Great work.

One other annoyance is scrolling. Because the autoscroll boundaries are so large and the autoscroll so rapid, it's frustrating to try to click something in the middle of a list. Just when you're getting close, it jumps away. Far away. The scroll wheel works well though.

iMartyn commented 3 years ago

Agreed, I found that a "magic wand" style remote was kinda impossible to use, but the "keyboard" arrow controls work fine. (I'm on an earlier model that doesn't have a magic remote, mine is an aftermarket that registers as mouse+kb). That being said, I doubt LG is going to go past the login screen anyway because they're probably not going to install a jellyfin server to test the app.

ferferga commented 3 years ago

@iMartyn We provide to stores reviewers information about how to use our demo servers. That's why we pass most of the reviewing process enforced by them.

DpunktKpunkt commented 3 years ago

Now that 10.7 is released I can't hardly wait finding Jellyfin in LG store :)

anthonylavado commented 3 years ago

Well, LG has advised all developers that there is a backlog causing reviews to take up to one month...

celerydoor commented 3 years ago

@anthonylavado Does that mean it's been submitted to LG and we're now waiting on their review?

ferferga commented 3 years ago

@celerydoor Yes, since around a week iirc.

Tyri0n commented 3 years ago

w00t! On 9 Mar 2021, 17:05 +0000, Fernando Fernández notifications@github.com, wrote:

@celerydoor Yes, since around a week iirc. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

anthonylavado commented 3 years ago

Rejected again by "pre-QA". This one took longer than just a day, so it seems they might have actually tried.

Off to read their comments and go for round three...

sorano commented 3 years ago

Shame, I mean that webos tv store is filled with 95% crap apps so it's weird that they reject a quality project like this (for probably bullshit reasons).

I hope the constant rejecting dont wear your morale down.

Best of luck!

DpunktKpunkt commented 3 years ago

Bummer! Are you going to publish their comments for better testing / fixing with more people?