jellyfin / jellyfin

The Free Software Media System
https://jellyfin.org
GNU General Public License v2.0
34.73k stars 3.16k forks source link

Bandcamp music not working #5940

Closed Octelly closed 3 years ago

Octelly commented 3 years ago

Describe the bug FLAC music downloaded from Bandcamp doesn't correctly load embedded tags and can't be played or downloaded.

System (please complete the following information):

To Reproduce

  1. Download music from Bandcamp (FLAC format) - WiiU Grooves from Dj CUTMAN is "name your price"
  2. Load it into Jellyfin just like with any other piece of media
  3. Tags loaded incorrectly or not at all and the media can't be played or downloaded

Expected behavior Media gets tagged based on the tags embedded in the file and can be played just like any other piece of media. (and downloaded too)

Logs

[2021-04-30 20:50:52.371 +02:00] [INF] session.RemoteEndPoint : "192.168.1.47"
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : event_playing_id     = "b2b3d2015a65dbc19f78a4a0c5378fdd"
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : event_user_id        = "20b9057276404f05b690c17104cf20d6"
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : event_user_id_int    = 1
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : session_playing_id   = ""
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : session_user_id      = "20b9057276404f05b690c17104cf20d6"
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : play_method          = "na"
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : e.ClientName         = "Jellyfin Media Player"
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : e.DeviceName         = "ocean-desktop"
[2021-04-30 20:50:52.372 +02:00] [INF] StartPlaybackTimer : ItemName             = "Not Known - 01 - Dj CUTMAN - WiiU Grooves - Hot Tea & Firmware Updates (Not Known)"
[2021-04-30 20:50:52.373 +02:00] [INF] StartPlaybackTimer : ItemId               = "b2b3d2015a65dbc19f78a4a0c5378fdd"
[2021-04-30 20:50:52.373 +02:00] [INF] StartPlaybackTimer : ItemType             = "Audio"
[2021-04-30 20:50:52.373 +02:00] [INF] StartPlaybackTimer : Details do not match for play item
[2021-04-30 20:50:52.373 +02:00] [INF] StartPlaybackTimer : Exited

Screenshots image No artist name

Additional context I think that's all.

Bitwolfies commented 3 years ago

Music I’ve downloaded from bandcamp has been fine, your artist probably just forgot to add their tags. Nothing special about how bandcamp tags stuff, it’s the same as any flac.

download mp3tag and take a look that it’s correct.

Octelly commented 3 years ago

Music I’ve downloaded from bandcamp has been fine, your artist probably just forgot to add their tags. Nothing special about how bandcamp tags stuff, it’s the same as any flac.

download mp3tag and take a look that it’s correct.

I've editted all of the tags with EasyTAG (Gnome project) and this happens only and with all of my music that I downloaded from Bandcamp. Weird it doesn't happen to you.

I'll look further into it on my side, but this really only happens to me with Bandcamp music and with all of it, even after editting the tags with EasyTAG. I'll especially take a look at mp3tag when I have the time and see if that helps, would be great if Jellyfin could deal with these files like any other media player though. (Lollypop (also Gnome) handles the files just fine)

Octelly commented 3 years ago

@Darkwolf1515 Mp3tag, unfortunately, isn't available for Linux and I don't have access to a working Windows machine.

Bitwolfies commented 3 years ago

image Works fine for me, how is your folder set up? (no, i retagged nothing)

Should be set up like this image

Octelly commented 3 years ago

image Works fine for me, how is your folder set up? (no, i retagged nothing)

Should be set up like this image

yeah, that is how I have it set up as well

image

I'm wondering if it could be somehow related to the host machine I'm using. It's a Raspberry Pi 4 running DietPi with Jellyfin installed from official repositories and the media being stored on an ext4 partition on an external drive.

I double-checked if the problem is still there and it certainly is, even after refreshing the tags.

There is one more thing I could think of. There used to be an NTFS partition on the disk and at one point I encountered an I/O error. I ended up powering off the host machine, copying the files from the drive somewhere else, reformatting it completely, and putting everything back onto an ext4 partition on the drive. I wonder if that I/O error could've possibly messed up Jellyfin's metadata database, even though it's saved on the Pi's microSD card...

Octelly commented 3 years ago

image Still a problem, even after updating to the newest version. (currently on 10.7.5)

Octelly commented 3 years ago

No longer a Bandcamp-only problem. image Same happened to an Animal Crossing New Horizons gamerip album. Still no idea why, all of the albums show up just fine in Lollypop. image image image

edit: all of it is in FLAC

Octelly commented 3 years ago

image Added Antidote today, which I bought from Beatport in wav audio format and losslessly converted to flac via Audacity and then tagged with EasyTAG as I do with all my music.

stale[bot] commented 3 years ago

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments. If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label. This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

Octelly commented 3 years ago

This issue still persists, however, I'll be reinstalling Jellyfin from the ground up on a new server soon. I'm hoping that this reinstallation could maybe solve the issue somehow.

Octelly commented 3 years ago

Now that I've reinstalled Jellyfin on a different server everything seems to be working fine again. My guess is that the cache or something like that got corrupted before and wasn't able to correct itself. Whatever the case may be, this issue is now solved for me.