search

jellypbc / poster

Jelly demo toy app that turns PDFs into editable posts
https://jellypbc.com
Other
22 stars 3 forks source link

Adds twitter card for collections #375

Closed cindywu closed 3 years ago

cindywu commented 3 years ago

This PR adds meta_title and meta_twitter_description to generate twitter cards for collections.

Updates twitter cards for posts, so title defaults to Untitled and author to Anonymous when those fields are not present.

Twitter cards cannot be tested locally, so this will be tested live.

Addresses #353

Collection twitter card design image

Post twitter card design image

linear[bot] commented 3 years ago
JEL-228 twitter card for collections

* [ ] make twitter card for collections pages `tags` * [ ] 2+ posts and 2+ references * [ ] 1 post and 2+ references * [ ] 2+ posts and 1 reference * [ ] 2+ posts and 0 references * [ ] 1 post and 0 references * [ ] 0 posts and 0 references ![Design System 2020-12-20 13-56-55.png](https://uploads.linear.app/5522bd94-0037-4b38-9adb-1a67abf87e7b/cd9123d3-0577-48f9-a9d3-888440505752/Design%20System%202020-12-20%2013-56-55.png "Design System 2020-12-20 13-56-55.png") ![cindy on Twitter: "https:::t.co:1CxNWCMiER" : Twitter 2020-11-08 17-21-43.png](https://uploads.linear.app/5522bd94-0037-4b38-9adb-1a67abf87e7b/839ee719-b688-4a9d-9ddf-ece216ddc255/cindy%20on%20Twitter:%20%22https:::t.co:1CxNWCMiER%22%20:%20Twitter%202020-11-08%2017-21-43.png 'cindy on Twitter: "https:::t.co:1CxNWCMiER" : Twitter 2020-11-08 17-21-43.png')