jellypbc / poster

Jelly demo toy app that turns PDFs into editable posts
https://jellypbc.com
Other
22 stars 3 forks source link

Typescript migration #404

Closed cindywu closed 3 years ago

cindywu commented 3 years ago

This PR is a second attempt at https://github.com/jellypbc/poster/pull/372.

@dennyluan I think we should merge this and close off the typescript migration project. I could work on this for another month (or longer), but I don't think that is the best use of our resources. I'd like for us to move onto cleaning up our redux stuff.

I think the current PR gives enough of a blueprint for us to follow.

@alexkrolick if you come across this and have thoughts or suggestions, would love to hear them!

My recommendation is we create .tsx files for new react components with the intention of no implicit anys and strict null checks. All javascript files should be .ts moving forward. For existing code, we fix and resolve as it conveniently overlaps with our product priorities.

linear[bot] commented 3 years ago

JEL-279 typescript migration again

dennyluan commented 3 years ago

There's still a good number of any's in here, but I think it's a good start and something we can continue to work on 🤞