search

jenkinsci / audit-log-plugin

Audit logging plugin for Jenkins based on Apache Log4j Audit
https://plugins.jenkins.io/audit-log/
MIT License
20 stars 22 forks source link

Log credentials usage #50

Closed aarthira closed 5 years ago

aarthira commented 5 years ago

This change aims to audit the credentials usage.

We try do this by listening to the SaveableListener as the usage of a credential creates a fingerprint.

jeffret-b commented 5 years ago

Let's try a close / reopen cycle to see if the build will run right next time.

jeffret-b commented 5 years ago

Kick the build again. I can't figure out why it's failing. It's working fine on my machine.

jeffret-b commented 5 years ago

OK, I'm mystified about the spotbugs failure. Passes fine on my machine. @jvz ?

jvz commented 5 years ago

I think I figured it out. I pushed a commit removing the null check, and now running mvn spotbugs:spotbugs results in a success rather than complaining about a null dereference. I think it's a spotbugs bug probably. 🤷‍♂

jvz commented 5 years ago

@aarthira make sure to run git pull --rebase if you made any local changes to pull down my commit before squashing anything. We can squash the PR at the end if you'd prefer rather than force pushing (which doesn't work well with GitHub's review UI unfortunately).

gayathrirajendar commented 5 years ago

@aarthira , As you asked, I also tried it locally. It runs well for me in local. I triggered a build here, again. It failed. Maybe as @jvz said, it is a bug.

jvz commented 5 years ago

Run mvn clean install spotbugs:spotbugs locally to see what the spotbugs error is.

jvz commented 5 years ago

Try updating to the parent pom 3.47. Maybe there's an update for spotbugs as well.

jeffret-b commented 5 years ago

As you can see in #55, the only thing I was able to get to work on the CI machine was to suppress the warning. Spotbugs is just wrong about something here, but I've been unable to tweak the code to get Spotbugs to be able to figure it out.

jvz commented 5 years ago

I'm able to reproduce the build failure locally by running mvn clean install spotbugs:spotbugs, though I can't tell what error it's complaining about. I'll see if I can figure out what's causing this.

jvz commented 5 years ago

@aarthira are you creating a new PR for this?

aarthira commented 5 years ago

@jvz , The tests were failing because of the halted early issue. So I was trying to force push to trigger it again. It didn't work. So I am trying close/reopen now.

jvz commented 5 years ago

There's some problems with ci.jenkins.io at the moment.

jvz commented 5 years ago

I'm getting a test failure when I run this locally in SaveableChangeListenerTest.

aarthira commented 5 years ago

Oh, That was a minor misunderstanding. I fixed it.

aarthira commented 5 years ago

Shall we merge this?