jenkinsci / aws-credentials-plugin

CloudBees Amazon Web Services Credentials Plugin
https://plugins.jenkins.io/aws-credentials/
MIT License
27 stars 72 forks source link

Silence warnings for fields with no getters #238

Closed rsandell closed 4 months ago

rsandell commented 4 months ago

Testing done

### Submitter checklist
- [ ] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [ ] Ensure that the pull request title represents the desired changelog entry
- [ ] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
rsandell commented 4 months ago

@amuniz are you able to merge and release this please?

amuniz commented 4 months ago

Sure. What warnings is this fixing BTW? IDE?

rsandell commented 4 months ago

There are sporadic system log serialization warnings about the class because of the missing getters.

rsandell commented 4 months ago

@amuniz Thanks for the merge! But this PR needs a significant label for the release to happen. :pray:

amuniz commented 4 months ago

@rsandell added. However I can't trigger the release pipeline manually, do you know of some way to trigger a release?

rsandell commented 4 months ago

https://github.com/jenkinsci/aws-credentials-plugin/actions/workflows/cd.yaml

rsandell commented 4 months ago

There should be a "Run Workflow button" somewhere there