search

jenkinsci / aws-credentials-plugin

CloudBees Amazon Web Services Credentials Plugin
https://plugins.jenkins.io/aws-credentials/
MIT License
27 stars 72 forks source link

Add global setting to disable credential checking against AWS #240

Open cperrin88 opened 3 months ago

cperrin88 commented 3 months ago

This pull request adds an option to disable the checking against AWS. The plugin is used in the caching plugin to store S3 credentials, even for local buckets. We don't need the credentials to be send to AWS. The changes are made in a way that preserves the current functionality by default.

Testing done

This was tested on our Jenkins instance and is currently active and in production. They work as expected.

The new settings look like this: Screenshot of the settings

### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [x] Link to relevant issues in GitHub or Jira
- [x] Link to relevant pull requests, esp. upstream and downstream changes
- [x] Ensure you have provided tests - that demonstrates feature works or fixes the issue
cperrin88 commented 1 month ago

Is there something missing? Do you need something to merge this?

cperrin88 commented 1 month ago

Fixes #241

cperrin88 commented 4 weeks ago

@andresrc or @amuniz or @escoem can you have a look?