jenkinsci / badge-plugin

Jenkins Badge plugin
https://plugins.jenkins.io/badge/
MIT License
32 stars 43 forks source link

Update dependency org.jenkins-ci.plugins:plugin to v5 #196

Closed renovate[bot] closed 1 month ago

renovate[bot] commented 1 month ago

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.jenkins-ci.plugins:plugin 4.88 -> 5.1 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.



This PR was generated by Mend Renovate. View the repository job log.

gounthar commented 1 month ago
[INFO] Scanning for projects...
19:58:33  [ERROR] [ERROR] Some problems were encountered while processing the POMs:
19:58:33  [ERROR] 'dependencies.dependency.version' for jakarta.servlet:jakarta.servlet-api:jar is missing. @ org.jenkins-ci.plugins:plugin:5.0, /home/jenkins/agent/workspace/Plugins_badge-plugin_PR-196@tmp/m2repo/org/jenkins-ci/plugins/plugin/5.0/plugin-5.0.pom, line 239, column 17
19:58:33   @ 
19:58:33  [ERROR] The build could not read 1 project -> [Help 1]
19:58:33  org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs:
19:58:33  [ERROR] 'dependencies.dependency.version' for jakarta.servlet:jakarta.servlet-api:jar is missing. @ org.jenkins-ci.plugins:plugin:5.0, /home/jenkins/agent/workspace/Plugins_badge-plugin_PR-196@tmp/m2repo/org/jenkins-ci/plugins/plugin/5.0/plugin-5.0.pom, line 239, column 17
19:58:33  
19:58:33      at org.apache.maven.project.DefaultProjectBuilder.build (DefaultProjectBuilder.java:389)
19:58:33      at org.apache.maven.graph.DefaultGraphBuilder.collectProjects (DefaultGraphBuilder.java:349)
19:58:33      at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor (DefaultGraphBuilder.java:340)
19:58:33      at org.apache.maven.graph.DefaultGraphBuilder.build (DefaultGraphBuilder.java:76)
19:58:33      at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:448)
19:58:33      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:197)
19:58:33      at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
19:58:33      at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
19:58:33      at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
19:58:33      at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
19:58:33      at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
19:58:33      at jdk.internal.reflect.DirectMethodHandleAccessor.invoke (DirectMethodHandleAccessor.java:103)
19:58:33      at java.lang.reflect.Method.invoke (Method.java:580)
19:58:33      at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:255)
19:58:33      at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:201)
19:58:33      at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:361)
19:58:33      at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:314)
19:58:33  [ERROR]   
19:58:33  [ERROR]   The project org.jenkins-ci.plugins:badge:2.2-rc424.ed419d3034a_b_ (/home/jenkins/agent/workspace/Plugins_badge-plugin_PR-196/pom.xml) has 1 error
19:58:33  [ERROR]     'dependencies.dependency.version' for jakarta.servlet:jakarta.servlet-api:jar is missing. @ org.jenkins-ci.plugins:plugin:5.0, /home/jenkins/agent/workspace/Plugins_badge-plugin_PR-196@tmp/m2repo/org/jenkins-ci/plugins/plugin/5.0/plugin-5.0.pom, line 239, column 17
19:58:33  [ERROR] 
19:58:33  [ERROR] Re-run Maven using the -X switch to enable full debug logging.
19:58:33  [ERROR] 
19:58:33  [ERROR] For more information about the errors and possible solutions, please read the following articles:
19:58:33  [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
MarkEWaite commented 1 month ago

The additional change that is needed in order to use plugin pom 5.0 is:

diff --git a/pom.xml b/pom.xml
index 9f3b15f..878bf9c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -49,7 +49,7 @@
   </scm>

   <properties>
-    <jenkins.version>2.440.3</jenkins.version>
+    <jenkins.version>2.479</jenkins.version>
     <revision>2.2</revision>
     <changelist>-SNAPSHOT</changelist>
     <gitHubRepo>jenkinsci/badge-plugin</gitHubRepo>
@@ -62,7 +62,7 @@
     <dependencies>
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
-        <artifactId>bom-2.440.x</artifactId>
+        <artifactId>bom-2.462.x</artifactId>
         <version>3413.v0d896b_76a_30d</version>
         <type>pom</type>
         <scope>import</scope>

However, I think it is too early to have new releases of the badge plugin require a Jenkins weekly release. The badge plugin does not have any javax.servlet imports and does not depend on any libraries that require Java 17. I think it should stay with the 4.x parent pom for now. That allows users of earlier Jenkins versions to continue installing new releases of the badge plugin.

MarkEWaite commented 1 month ago

Closing this pull request since both @strangelookingnerd and @gounthar gave a 👍 to the idea that it is not yet the right time to require Jenkins 2.479 and Java 17 in the badge plugin. If I understand correctly, that should cause Renovate to not reopen the same version.

renovate[bot] commented 1 month ago

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update. You will not get PRs for any future 5.x releases. But if you manually upgrade to 5.x then Renovate will re-enable minor and patch updates automatically.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.