Closed strangelookingnerd closed 2 weeks ago
Following a brief discussion with @MarkEWaite (https://github.com/jenkinsci/groovy-postbuild-plugin/pull/81#issuecomment-2404998761) I propose to get rid of the *.gif images.
In order to not break current pipelines an on-the-fly replacement should be implemented. See the following table for my proposal:
status-blue
cloud-upload-outline
cloud-download-outline
trash
status-red
folder
green_square
information-circle
red_square
save-outline
document-text
status-yellow
yellow_square
Some of the icons do not have proper replacements from the core (https://github.com/jenkinsci/jenkins/tree/master/war/src/main/resources/images/symbols) or the ionicons-api-plugin. That's why I added emoji-symbols-api as a dependency to find the missing pieces.
ionicons-api-plugin
emoji-symbols-api
Any feedback is highly welcome!
Added tests to cover the replacement
@basil That must have slipped my mind - sorry for the fuzz.
Following a brief discussion with @MarkEWaite (https://github.com/jenkinsci/groovy-postbuild-plugin/pull/81#issuecomment-2404998761) I propose to get rid of the *.gif images.
In order to not break current pipelines an on-the-fly replacement should be implemented. See the following table for my proposal:
status-blue
cloud-upload-outline
cloud-download-outline
trash
status-red
folder
green_square
information-circle
red_square
save-outline
status-blue
document-text
status-yellow
yellow_square
Some of the icons do not have proper replacements from the core (https://github.com/jenkinsci/jenkins/tree/master/war/src/main/resources/images/symbols) or the
ionicons-api-plugin
. That's why I addedemoji-symbols-api
as a dependency to find the missing pieces.Any feedback is highly welcome!
Testing done
Added tests to cover the replacement
Submitter checklist