jenkinsci / badge-plugin

Jenkins Badge plugin
https://plugins.jenkins.io/badge/
MIT License
32 stars 43 forks source link

Replace old GIFs with symbols #208

Closed strangelookingnerd closed 2 weeks ago

strangelookingnerd commented 3 weeks ago

Following a brief discussion with @MarkEWaite (https://github.com/jenkinsci/groovy-postbuild-plugin/pull/81#issuecomment-2404998761) I propose to get rid of the *.gif images.

In order to not break current pipelines an on-the-fly replacement should be implemented. See the following table for my proposal:

name old new origin
completed.gif Image grafik core status-blue
db_in.gif Image grafik ionicons cloud-upload-outline
db_out.gif Image grafik ionicons cloud-download-outline
delete.gif Image grafik core trash
error.gif Image grafik core status-red
folder.gif Image grafik core folder
green.gif Image grafik emoji green_square
info.gif Image grafik core information-circle
red.gif Image grafik emoji red_square
save.gif Image grafik ionicon save-outline
success.gif Image grafik core status-blue
text.gif Image grafik core document-text
warning.gif Image grafik core status-yellow
yellow.gif Image grafik emoji yellow_square

Some of the icons do not have proper replacements from the core (https://github.com/jenkinsci/jenkins/tree/master/war/src/main/resources/images/symbols) or the ionicons-api-plugin. That's why I added emoji-symbols-api as a dependency to find the missing pieces.

Any feedback is highly welcome!

Testing done

Added tests to cover the replacement

Submitter checklist

strangelookingnerd commented 2 weeks ago

@basil That must have slipped my mind - sorry for the fuzz.