search

jenkinsci / fortify-plugin

Fortify Jenkins plugin
https://plugins.jenkins.io/fortify
Other
23 stars 31 forks source link

don't bail out when executable wasn't found initially #23

Closed ashnazg closed 4 years ago

ashnazg commented 4 years ago

Fix for #21

I think the plugin was able to work via container back in 19.x because this executable finder failure did not choose to bail out with an exception. Even though it didn't find anything, allowing the container execution to continue ended up showing that it could still run everything successfully. The introduction of this exception in 20.x now blocks that from continuing.

I've removed the exception, and just left it as logging the fact that the finder didn't find the executable. If the plugin later fails to properly execute, then presumably another exception will occur at that point.

ashnazg commented 4 years ago

Built and installed with this change, and my new container with the 20.1.0 SCA client on it now works again.

ashnazg commented 4 years ago

(both build failures are due to disk space on the Windows build)

volkdir commented 4 years ago

As we need this, can someone have a look on it. Everything looks good beside the diskspace issue

vrulevskyi commented 4 years ago

Hi @ashnazg please, check out this note from ReadMe file in a new Fortify Jenkins plugin release v20.2.34. In case if you need further help, please, open a new issue or create another pull request. Closing the request in this regard.