search

jenkinsci / google-compute-engine-plugin

https://plugins.jenkins.io/google-compute-engine/
Apache License 2.0
57 stars 88 forks source link

Refresh plugin for August 2023 (Upgrade to a minimum core version 2.387.3 and minimum Java version 11) #403

Closed basil closed 1 year ago

basil commented 1 year ago

Currently blocking https://github.com/jenkinsci/bom/pull/2440

basil commented 1 year ago

Currently blocking https://github.com/jenkinsci/bom/pull/2440

olamy commented 1 year ago

I take the opportunity to modify the title. I hope this doesn't alter too much the content of your work.

basil commented 1 year ago

Thanks. I generally don't include minimum core version changes in release notes for the plugins I maintain (unless the minimum core version is unusual, like a weekly release or a very recent LTS) because such plugin releases aren't even advertised in the UI to users of older cores. Similarly, a recent core version implies a minimum Java version, and users running older Java versions (and therefore older cores) wouldn't get an advertisement for such a plugin upgrade in the UI, so I generally don't include minimum Java version changes in release notes. I have filed dozens (hundreds?) of PRs without this information in the title and shipped dozens of releases without this information in the release notes, all without any complaints from users or other developers. But I acknowledge that as the plugin maintainer, you should be free to include (or not include) any information you want in the release notes. I hope that this discussion about writing release notes has not been a significant distraction from the comparatively far more laborious task of modernizing the plugin itself.