Pass FindBugs Analysis - Githubissues

jenkinsci / in-toto-plugin

A Jenkins plugin to track steps and create in-toto link metadata

https://plugins.jenkins.io/in-toto/

MIT License

10 stars 14 forks source link

Pass FindBugs Analysis #8

Closed mjz3 closed 5 years ago

mjz3 commented 5 years ago

[x] This commit resolves bugs reported by maven FindBugs plugin

SantiagoTorres commented 5 years ago

This seems to be failing because of the docker-based integration tests.

mjz3 commented 5 years ago

This seems to be failing because of the docker-based integration tests.

There is a bug report from FindBugs regarding the unused URI variable in Transport.java First I decided to remove the variable in commit 219fecea9cd16574a47706c054a4c03388df6b72 which results in docker error for (prepare-etcd-server). Now I put the variale back in the place in commit 2ed44dd37f48b7a5d8542b471919117d602038a2 which resolved the docker issue, but still FindBugs reports it.

Should we ignore this bug?

mjz3 commented 5 years ago

as I read in the logs, the jenkinsfile is read from commit 407a2d155a9bf8058d42bce412fa55115b2f0795 which is part of master! I think we should directly commit in master!

SantiagoTorres commented 5 years ago

@m0jt4b4 looks good! thanks!