Fixes for BigDecimal proxy class

jenner / LstGen

Code-Generator für die Lohnsteuerberechnung aus PAP XML

MIT License

47 stars 16 forks source link

Fixes for BigDecimal proxy class #20

Closed tina-junold closed 3 years ago

tina-junold commented 3 years ago

since v0.6.0 of brick/math:

withScale was replaced by toScale
toInteger was renamed toInt

jenner commented 3 years ago

Thanks! Any way to make this backwards compatible?

tina-junold commented 3 years ago

Theoretically yes, but the question is why? Version 0.5.x of brick/math supports PHP 5.6 and 7.0, but both version are no longer supported. All following versions of brick/match support PHP 7.1 (or higher), while only PHP 7.4 and PHP 8.0 are officially supported by PHP. Every hoster I know supports different PHP versions, but at least PHP 7.1.

jenner commented 3 years ago

OK, works for me, could you add a note to lstgen/generators/php/BigDecimal.php stating that version >=v0.6.0 is required?