search

jennykim1016 / SLRealizer

Catalog-level simulation of LSST DM stack measurements of gravitationally-lensed quasars.
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Pull Request from obs_err branch #27

Closed jennykim1016 closed 7 years ago

jennykim1016 commented 7 years ago

I am going to work on generating the mock data set! Null deblending is ready (moment_experiment).

drphilmarshall commented 7 years ago

Very good! Can you assign a reviewer please, and let us know when you need code review done by? You can also say something about what kind of code review you would like (eg just look for glaring errors, line by line inspection for python style, advice on code structure, gaps in documentation etc). By default you get a general review for everything but this is this can be asking a lot of your reviewers!

jennykim1016 commented 7 years ago

Hi Dr. Marshall and Mike,

I assigned Mike as a reviewer. It would be great if I could get a review on noticeable errors in the code and the general inspection of python style. By Wednesday would be great so that I could finalize the code before the Thursday meeting, but no rush please!

Thanks, and have a nice week! :)

jennykim1016 commented 7 years ago

Hi Mike,

1&2 : Sorry -- I thought my local repo and the github repo were synced, but I think I forgot to git rm after local rm commands. I deleted those unnecessary files! 4: Similarly, I should have removed this file from Git. Testing.py was used to experiment with some codes. The unit tests for gaussians are in test.py, which can be run with the command nosetests. 3 & 5 : I renamed the file / added summaries to the file.

Thank you so much for your help! :)

jennykim1016 commented 7 years ago

I am not using this branch anymore, the most-to-date version is in obs_err_ext. Closing the pull request.