jens-maus / RaspberryMatic

:house: A feature-rich but lightweight, buildroot-based Linux operating system alternative for your CloudFree CCU3/ELV-Charly 'homematicIP CCU' IoT smarthome central. Running as a pure virtual appliance (ProxmoxVE, Home Assistant, LXC, Docker/OCI, Kubernetes/K8s, etc.) on a dedicated embedded device (RaspberryPi, etc.) or generic x86/ARM hardware.
https://raspberrymatic.de
Apache License 2.0
1.52k stars 186 forks source link

groups can't be changed if there is a new device in the inbox #1437

Open grunes opened 2 years ago

grunes commented 2 years ago

Describe the bug It's not longer possible to edit groups if there is a new device in the inbox. Web-UI is freezing during device configuration. Seams to be a re-bug of #945

Steps to reproduce the behavior

  1. Add a new device, must be in the inbox ("Posteingang")
  2. Edit a group (e.g. remove a device)
  3. press OK button

Expected behavior group should be saved without the deleted device.

Screenshots image

System information:

Additional context after removing the new device from the inbox, the group can be saved as expected.

jens-maus commented 2 years ago

Usual question: @Baxxy13 @jp112sdl can you reproduce this issue? My feeling is that this might be some internal issue in the web parts in HMIPServer which we don't have access to in the end. Would be great if someone can try to reproduce it.

jp112sdl commented 2 years ago

I cannot test adding/removing devices to an HmIP-group, because I have no HmIP devices.

But with having a BidCos device in the inbox, I can create/delete/edit a "classic HM" group without any error and I can create/delete an empty HmIP-group, too.

Baxxy13 commented 2 years ago

I can reproduce this and maybe found something. The teached in device (HmIP-SCI in this case) which is still located in the inbox... SCI in Posteingang

... will showed as an addable device, but without icon and an unconventional name. IP-GRUPPE bei Gerät im Posteingang_A

Adding this strange device or any other possible device ends up in the rotating circle. IP-GRUPPE bei Gerät im Posteingang_B

Sorry für's holprige Englisch. Darf gerne korrigiert werden.

grunes commented 2 years ago

We even can switch to German!

stale[bot] commented 2 years ago

Thanks for your contribution! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of RaspberryMatic and tell us. Also check that all relevant details,


Vielen Dank für die Unterstützung! Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüfen Sie, ob das Problem auch in der aktuellsten Version von RaspberryMatic noch relevant ist, und teilen Sie uns dies mit. Überprüfen Sie auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind oder aktualisiert werden müssen.

grunes commented 2 years ago

any updates?

stale[bot] commented 2 years ago

Thanks for your contribution!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days. Please check if the issue is still relevant in the most current version of RaspberryMatic and tell us. Also check that all relevant details,


Vielen Dank für die Unterstützung!
Dieses Problem wurde automatisch als veraltet markiert, da es in letzter Zeit keine Aktivitäten gab. Es wird geschlossen, wenn nicht innerhalb der nächsten 7 Tage weitere Aktivitäten stattfinden. Bitte überprüfen Sie, ob das Problem auch in der aktuellsten Version von RaspberryMatic noch relevant ist, und teilen Sie uns dies mit. Überprüfen Sie auch, ob alle relevanten Details, Logs und Reproduktionsschritte enthalten sind oder aktualisiert werden müssen.

rene-re commented 1 year ago

image

Baxxy13 commented 1 year ago

Known problem in the actual RaspberryMatic. Solutions:

jens-maus commented 1 year ago

You forgot to mention also: Read carefully through an existing ticket/issue before hijacking it because this issue here is substantially different because it relates to the point that adding groups is not possible if there is a device waiting in the inbox!

rene-re commented 1 year ago

Thanks for the swift response and help. I also noted your feedback that my response is not identical - should it might provide additional context. Thanks! @jens-maus @Baxxy13

sikraemer commented 7 months ago

Hi,

I ran into this issue today. Same error message as in the original post. My setup is running on version 3.73.9.20231130 on a RPi4 through the HomeAssistant Addon.

I could pinpoint the error to occur here. Generally when devices are added to the assignableDevices of the viewModel here, the device member is not set if the device is still in the inbox.

I am not sure if the problem is caused by the response caused by either of these 3. Each of them can be adjusted to fix the problem.

Any input on the direction of how the fix should be applied would be appreciated.

@jens-maus @grunes