search

jensjeflensje / minecraft_imagery

Toolkit for taking pictures and videos in Minecraft
https://www.spigotmc.org/resources/imageryapi-take-pictures-in-minecraft.111347/
MIT License
18 stars 4 forks source link

Chore: Cleanup warnings #15

Closed ConnorBP closed 1 week ago

ConnorBP commented 2 weeks ago

Added some null type checking as well as removed unused imports to remove as many warnings as possible. Have not removed the deprication warning for clazz.newInstance() though. https://github.com/jensjeflensje/minecraft_imagery/blob/16658fcaf4bfcc25c357e24fa3f4f266593d6b65/src/main/java/dev/jensderuiter/minecraft_imagery/compatibility/PatchInitializer.java#L44

This one would need your input.

ConnorBP commented 2 weeks ago

@jensjeflensje is this good to merge?

jensjeflensje commented 2 weeks ago

I'll take a closer look and merge later, but I think it looks good.

The only thing I'm not quite sure about is the build.cmd script. I understand why you put it in, but it only supports windows, only works when your jdk is in that specific path, and I don't think anyone would really use it. I use IntellIJs builtin maven tooling and I think it's better to just have people use that, anything else, rather than putting it inside the repo.

ConnorBP commented 1 week ago

@jensjeflensje sorry for the delay, the script is removed

jensjeflensje commented 1 week ago

Great! Thanks for the PR :) It'll be included in the next release