search

jenssegers / php-proxy

A PHP proxy script with https and post support
https://jenssegers.com
932 stars 266 forks source link

Zend\Diactoros\Response\SapiEmitter has been depricated #75

Closed rustygoldcoin closed 4 years ago

rustygoldcoin commented 4 years ago

Zend\HttpHandlerRunner\Emitter\SapiEmitter is the replacement for the deprecated class. As a part of updating this, you will need to remove the use of "zendframework/zend-diactoros": "^1.0 || ^2.0", and update it with "zendframework/zend-httphandlerrunner": "^1.1"

jmolivas commented 4 years ago

@jenssegers will you accept a PR with this changes updating the deprecated dependencies? I got a fork with this changes applied.

jenssegers commented 4 years ago

Sure thing!

jmolivas commented 4 years ago

@jenssegers PR is here https://github.com/jenssegers/php-proxy/pull/78

CircleCI is complaining when PHP version < 7.1 https://travis-ci.org/jenssegers/php-proxy/jobs/659028737

image

7.0 and even 7.1 are deprecated now, not sure if CircleCI should keep testing those deprecated versions, what do you think? https://www.php.net/supported-versions.php

jmolivas commented 4 years ago

PR was merged this should be closed