jereeemyyyy / pe

0 stars 0 forks source link

Overzealous input validation #8

Open jereeemyyyy opened 2 weeks ago

jereeemyyyy commented 2 weeks ago

Screenshot 2024-11-15 at 5.14.10 PM.png

According to the website:

Screenshot 2024-11-15 at 5.15.32 PM.png

nus-pe-script commented 1 week ago

Team's Response

Thank you for your input. The consideration behind these fields is to convey that these are meant to store quick and convenient information, and was not designed to store large amounts of information regarding a patient. Having long inputs could potentially disrupt the CLI-usability as they might have to use their mouse to scroll through the data, which defeats the purpose of a CLI Application. In addition, we also have the patient notes field to add additional information regarding a patient, which could be used for a more general purpose (i.e. to store more diagnosis data if the 80 characters is insufficient.). Hence, this was an intended implementation.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Thank you for your response!

I understand the restriction is indeed an intended implementation which is nothing wrong. However, I am suggesting that this particular restriction is overzealous in the sense that it restricts the user's input for the NOTE and DIAGNOSIS fields to only 80 characters when in fact, it is reasonable for a Nurse/Doctor to have a DIAGNOSIS or NOTE longer than 80 characters. This was the reason why I think that this could be an issue of type.FeatureFlaw and severity.Low.

The following points are to address the response: `"In addition, we also have the patient notes field to add additional information regarding a patient, which could be used for a more general purpose (i.e. to store more diagnosis data if the 80 characters is insufficient.)":

Therefore, I believe that this issue is still of type.FeatureFlaw and severity.Low which are the original types that I have inputted during the PE.