vsg: print file name when ClassifyError

alonbl commented 3 months ago

In current implementation the user see something like the following when ClassifyError is raised:

    Error: Unexpected token detected while parsing procedure_call_statement @ Line 49, Column 22 in file None
           Expecting : ;
           Found     : )

In a project that contains multiple files, the user is clueless as he does not know which of the files caused the error.

This change adds the name of the file to the message.

    Error while processing xxx:
    Error: Unexpected token detected while parsing procedure_call_statement @ Line 49, Column 22 in file None
           Expecting : ;
           Found     : )

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.11%. Comparing base (baf22da) to head (0aa39ba). Report is 40 commits behind head on master.

Files with missing lines	Patch %	Lines
vsg/apply_rules.py	50.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1210 +/- ## ========================================== + Coverage 94.01% 94.11% +0.09% ========================================== Files 1557 1569 +12 Lines 29028 29407 +379 Branches 3414 3472 +58 ========================================== + Hits 27291 27675 +384 + Misses 1303 1299 -4 + Partials 434 433 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jeremiah-c-leary commented 2 months ago

Evening @alonbl ,

Thanks for the update with the file name. That was something I always wanted to do but never seemed to find the time.

I will get this merged to master for the next release.

Regards,

--Jeremy

jeremiah-c-leary / vhdl-style-guide

vsg: print file name when ClassifyError #1210

Codecov Report