jeremiah-c-leary / vhdl-style-guide

Style guide enforcement for VHDL
GNU General Public License v3.0
192 stars 40 forks source link

Issue#1243: Fixed external names parsing bug #1244

Closed JHertz5 closed 1 month ago

JHertz5 commented 1 month ago

Resolves #1243.

I've solved the problem by iteratively checking for opening parentheses at the end of the current portion of the pathname,e .g .

probe_signal <= << constant some.hierarchy.hier(i).test(i).my_loop(i).test : std_logic >>;
-- while loop checks at these points           ^       ^          ^       ^

It's possible that an alternative solution would be to absorb the parentheses into the pathname token? But perhaps the parentheses are separated to allow for multiline indentation rules and we need to keep them separate. Happy to hear any feedback.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.19%. Comparing base (baf22da) to head (24166b6). Report is 45 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1244 +/- ## ========================================== + Coverage 94.01% 94.19% +0.17% ========================================== Files 1557 1602 +45 Lines 29028 29768 +740 Branches 3414 3499 +85 ========================================== + Hits 27291 28040 +749 + Misses 1303 1293 -10 - Partials 434 435 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.