Closed doodspav closed 11 months ago
Thank you for the PR! I will review as soon as I can.
Follow up things you should probably do:
cpptrace
) which gets installed along with libassert
even when being linked as a private dependency<assert/assert_export.hpp>
that gets generated by CMake; you can include this without needing a relative include path, and you should mark all the symbols you want to be exported with ASSERT_EXPORT
because right now all symbols are private (even on linux)assert::assert
instead of assert
(which no longer exists)Bear in mind that cpptrace
's CMake breaks consuming an installed version of libassert
consumed via find_package
Thank you again for this PR, I have integrated much of your recommendations for structure and functionality of the CMake into cpptrace on the dev branch and things seem to work well there. I will give this PR a more thorough review this weekend.
Running the CI now, some test failures are expected. No worries that there are some.
3.8 .. 3.23
to just3.14