jeremy-rifkin / libassert

The most over-engineered C++ assertion library
MIT License
539 stars 36 forks source link

Correct CMake issues #68

Closed doodspav closed 11 months ago

doodspav commented 1 year ago
jeremy-rifkin commented 1 year ago

Thank you for the PR! I will review as soon as I can.

doodspav commented 1 year ago

Follow up things you should probably do:

doodspav commented 1 year ago

Bear in mind that cpptrace's CMake breaks consuming an installed version of libassert consumed via find_package

jeremy-rifkin commented 12 months ago

Thank you again for this PR, I have integrated much of your recommendations for structure and functionality of the CMake into cpptrace on the dev branch and things seem to work well there. I will give this PR a more thorough review this weekend.

Running the CI now, some test failures are expected. No worries that there are some.