search

jeremy-rifkin / libassert

The most over-engineered C++ assertion library
MIT License
539 stars 36 forks source link

use FetchContent for magic_enum #71

Closed flagarde closed 11 months ago

jeremy-rifkin commented 11 months ago

Thanks so much, sorry again for my mistake! Do you want to handle the merge conflict or should I?

jeremy-rifkin commented 11 months ago

Ok, I verified I know how to push properly to a contributor branch so I will take the liberty of merging

jeremy-rifkin commented 11 months ago

I think the test failures are superficial. I'll merge and tweak as needed. Thanks so much for the contribution and apologies again for my clumsiness!

jeremy-rifkin commented 11 months ago

Ok, got everything working. One thing I had to do was link magic_enum::magic_enum publicly, does that sound alright to you?

flagarde commented 11 months ago

Yes PUBLIC seems better as you use it on templates