Closed villares closed 4 years ago
Great -- will review soon!
repo etiquette faux pas
No worries -- I am still learning myself. My main goal is that your commits always end up in the tree with you as the committer, crediting your work.
Your one major pull request #47 with the reorganization I didn't merge -- I cherry picked your commits and then closed the pull -- but from here on we'll try to make sure that your pulls themselves are worked on and merged so that they will show as merged in GitHub.
Okay, wow, I see what was going on here. I rebased several times and it kept generating really weird merge conflict sets. git really doesn't like file renaming that is case-change-only.
In the future, the way to deal with that is
git mv -f MyFile_path/MyFile_name MyFile_Path/MyFile_Name
Anyway: Closed by e369f5dc5 , db6181741 , 6fa051851
I'm very unsure about header style and I will be glad to make any corrections.
And please also forgive any git repo etiquette faux pas, I still struggle with simple things like updating my fork to upstream.
ref: issue #50