search

jeroenrinzema / commander

Build event-driven and event streaming applications with ease
MIT License
66 stars 5 forks source link

Feedback v2 #4

Closed vkuznecovas closed 6 years ago

vkuznecovas commented 6 years ago

Hello,

First of all, sorry if it does not build - I did not bother setting up the deps required, this is just intended to show how I'd handle the switch(or get rid of it altogether). DIsmiss if you feel like it :) Ignore the other PR, i managed to destroy history. Force pushes for the win.

jeroenrinzema commented 6 years ago

Hi,

First of all, thank you for taking a look at the project. I like your approach to the switches and I agree that this could be a good solution when having a switch statement that needs to be flexible. In this case am I not sure if this approach will add a lot of unnecessary complexity to the method. This switch statement will most likely not grow over time to keep the header of the Kafka messages light weight.