search

jerone / UserScripts

🐵 My UserScripts
https://github.com/jerone/UserScripts#readme
GNU General Public License v3.0
339 stars 39 forks source link

(GitHub News Feed Filter) The addition of the tab 'Discover repositories' in the News Feed has broken the script functionality #121

Closed darkred closed 6 years ago

darkred commented 6 years ago

Using FF 56.0.1 (tested in a clean profile too) with GM 3.17 and script v7.2.0.

Yesterday, an extra tab, 'Discover repositories' was added in the News Feed (blog post). Unfortunately, this has broken the script functionality:

There's no entry in Browser Console when this happens.


@jerone, it would be great if you fixed the script, to work with the new layout. I love your script!

jerone commented 6 years ago

Yeah, just got the new layout too. Already working on it, but it's not a simple replace classnames. They completely rewrote all news alerts. I hope to finish it this weekend.

jerone commented 6 years ago

@darkred Do you have any issue related news items in your news list?

darkred commented 6 years ago

No, I haven't. any.. It must be a GitHub bug: I got an email notification for a new issue in the Greasemonkey repo (2616), but it doesn't appear in the news feed.

jerone commented 6 years ago

Me neither. No issues and PR related news (and gist, but that could be because there isn't any in my feed). Also wondering if it's temporary or by design...

jerone commented 6 years ago

I also remembered news items about members being added to repos. Those are gone too.

jerone commented 6 years ago

I just pushed code changes that (hopefully) restores a working version of this userscript. I've not updated version numbering, because I was wondering if you have time to test it before releasing...

darkred commented 6 years ago

Of course. It's working great, again. Thank you!

I also contacted the GitHub support about the missing entries in the News Feed.
I'll let you know, as soon as I get a reply from them.

darkred commented 6 years ago

Unfortuntately it's a feature.. Here is the response:

What you're seeing is not a bug, but instead is the result of some updates we've made to our news feed. The updated feed focuses on helping users find open source repositories that line up with their interests, which you'll see in the new Discover repositories.

The Browse activity tab has also been streamlined, and certain events, such as Pull Requests and Issue comments, are no longer included. You can still see these events if you check your notifications page.

We're very interested in any feedback users like yourself have on these changes, so do please let us know what these changes will mean for how you use GitHub. It sounds like these changes may not be ones you consider an improvement, but any comments we receive will be included in our ongoing conversations about how to improve GitHub.

And my reply: (at least I tried!)

Unfortunately I don't find practical the removal of these entries from the News Feed - in fact I find it confusing to have only some of them in the News Feed, and the rest in Notifications. I find issue entries equally important as the other entry types, because a posted issue could affect me as a user too, and the News Feed is the quickest way to notice it. And PRs as well: it's good to get informed of the suggested contributions in the various repos that I watch, as they are submitted - not after getting merged.

Frankly, instead of moving these entry types from the News Feed to Notifications, I'd suggest adding them back, and just incorporate this excellent userscript https://github.com/jerone/UserScripts/tree/master/Github_News_Feed_Filter , which makes filtering (by Action Type, Repository and/or Users, i.e. you may apply filters from all these 3 filter categories, simultaneously) a breeze!

-In case you've already read my last comment with my suggestion to you for the usernames order in the 'Users' tab- - sorry about that, I deleted it. It's fine as it is.

jerone commented 6 years ago

I don't expect them to restore it, so those (and Member Add and Gists) are removed for now (we can always revert the commit).

I just updated the userscript, if you can test again, that would be great. I probably release a new version tonight or tomorrow.

Edit: About the user sorting; that seemed logic to me because the list of users always changes, and if you search for an user it's now easier to find. Another direction would have been sorting on amount of matches.

jerone commented 6 years ago

I just released the new version of Github News Feed Filter 🎬

I've not confirmed that every filter is working (because they weren't in my news feed), so if you see anything not working let me know. The total amount of filters should always be a factor of 30.

Thanks for helping with testing 🥇