jessecooper / pyetrade

Python E-Trade API Wrapper
GNU General Public License v3.0
205 stars 96 forks source link

New Functions, Fixes and Formatting #91

Closed Robert-Zacchigna closed 4 months ago

Robert-Zacchigna commented 4 months ago

Hello @jessecooper, I'm back again with some fixes, formatting and two new functions.

Please review at your leisure, I'll leave the version bump up to you.

ALSO, I think you need to manually run whatever process you have to update the docs site, as it is still showing an older version (preferably after these changes are merged if you approve).

I tried to see if it was something i could do but i don't think it is (please let me know though).

Thank you.

Major Changes

Minor Changes

jessecooper commented 4 months ago

Thanks @Robert-Zacchigna , I will start reviewing these changes.

Robert-Zacchigna commented 4 months ago

@jessecooper I have replaced pipenv with poetry, which thankfully wasn't too difficult to do. I have setup the .toml file, updated the pre-commit config with poetry hooks, updated and locked the dependencies using poetry and updated the devel section of the readme.

Robert-Zacchigna commented 4 months ago

@jessecooper Ok I have updated the poetry installation method to simply use pip

I have also made it explicit when a variable is None (not being used) and updated the supported python versions in setup.py (removing 3.8 and adding 3.12).

jessecooper commented 4 months ago

@Robert-Zacchigna Thank you for all your work on this. You have done a great amount of work to modernize and improve this package. Thank you! I will bump and push as soon as I can.

jessecooper commented 4 months ago

Also, I will give a look into the docs issue.

jessecooper commented 4 months ago

@Robert-Zacchigna Thanks for the heads up on the docs issue. I got that all worked out. Latest docs are up here: https://pyetrade.readthedocs.io/en/latest/