jesseduffield / lazydocker

The lazier way to manage everything docker
MIT License
38.7k stars 1.23k forks source link

feat: add volume `CreatedAt` field to volumes Config side panel #501

Closed m-mead closed 11 months ago

m-mead commented 1 year ago

This MR adds the CreatedAt value associated with a Docker volume to the volumes Config side panel. Here is an example of how the value looks, and how it matches the output of docker volume inspect <volume>.

$ docker volume inspect vscode
[
    {
        "CreatedAt": "2022-11-07T21:06:17Z",
        "Driver": "local",
        "Labels": {},
        "Mountpoint": "/var/lib/docker/volumes/vscode/_data",
        "Name": "vscode",
        "Options": {},
        "Scope": "local"
    }
]
image
m-mead commented 1 year ago

After making the change, I did notice the Create field in the Images > Config side panel seem to be a formatted to the local timezone. I'm happy to make the change to do the same for the volume CreatedAt field for consistent look and feel. Or I can leave it as is. Either works for me.

Example of the Crated field in the Images > Config side panel

image
mark2185 commented 11 months ago

Given that you've closed the PR, are you against someone else taking this up and crediting you as the author?

m-mead commented 11 months ago

Given that you've closed the PR, are you against someone else taking this up and crediting you as the author?

Hey @mark2185, I closed it because I didn't open an issue first like the contributing docs ask, so I figured this would not be accepted. If this functionality is desired I'd prefer to see it through and can reopen the PR or create an issue for discussion.