Open argorain opened 11 months ago
And before you ask, I cannot share that repository since it is corporate private repository.
Hi, I don't know GO so I don't think I'll submit any bugfix but I did some debugging and found following:
-
in .git/config which is odd[core]
repositoryformatversion = 0
filemode = false
bare = false
logallrefupdates = true
symlinks = false
ignorecase = true
[submodule]
active = .
[submodule "lib/cpputest"]
url = https://bitbucket.velux.com/scm/tech_ap/cpputest.git
[submodule "product/stm32g/tests/integration-test"]
url = https://bitbucket.velux.com/scm/tech_ap/stm-product-integration-test.git
[submodule "lib/cspy-cov"]
url = https://bitbucket.velux.com/scm/tech_ap/iar-cspy-to-llvm-cov.git
[submodule "lib/batch-build"]
url = https://bitbucket.velux.com/scm/tech_ap/iar-batch-build.git
[submodule "lib/iar-batch-build"]
url = https://bitbucket.velux.com/scm/tech_ap/iar-batch-build.git
[remote "upstream"]
url = https://bitbucket.velux.com/scm/library/actuator-platform.git
fetch = +refs/heads/*:refs/remotes/upstream/*
[branch "activation-skipped"]
remote = upstream
merge = refs/heads/activation-skipped
[branch "ci/jenkinsfile"]
remote = upstream
merge = refs/heads/ci/jenkinsfile
[branch "redesing/microwink"]
remote = upstream
merge = refs/heads/redesing/microwink
[branch "doxygen/position-getas"]
remote = upstream
merge = refs/heads/doxygen/position-getas
[-remote "origin"]
url = https://bitbucket.velux.com/scm/tech_ap/actuator-platform.git
fetch = +refs/heads/*:refs/remotes/origin/*
[branch "3.0/ci-changes"]
remote = upstream
merge = refs/heads/3.0/ci-changes
[branch "3.0/doxygen/CPP-1095-powerfail-as-an-architect-i-need-platform-to-support-new-power-fail-protocol"]
remote = upstream
merge = refs/heads/3.0/doxygen/CPP-1095-powerfail-as-an-architect-i-need-platform-to-support-new-power-fail-protocol
[branch "3.0/master"]
remote = upstream
merge = refs/heads/3.0/master
[branch "3.0/conf-voltage-levels"]
remote = upstream
merge = refs/heads/3.0/conf-voltage-levels
[branch "3.0/lower-vrefbuf"]
remote = upstream
merge = refs/heads/3.0/lower-vrefbuf
[branch "3.0/fix-vrefmax"]
remote = upstream
merge = refs/heads/3.0/fix-vrefmax
[branch "3.0/redesign/MCv2-Trim-current-position-before-current-update"]
remote = upstream
merge = refs/heads/3.0/redesign/MCv2-Trim-current-position-before-current-update
[branch "fix-deep-sleep-disabling"]
remote = upstream
merge = refs/heads/fix-deep-sleep-disabling
[branch "setup-nib-mains"]
remote = upstream
merge = refs/heads/setup-nib-mains
[branch "3.0/remove-reset-block-dependency"]
remote = upstream
merge = refs/heads/3.0/remove-reset-block-dependency
[branch "3.0/vpp-remove-warining"]
remote = upstream
merge = refs/heads/3.0/vpp-remove-warining
[branch "3.0/vvl/acmp"]
remote = upstream
merge = refs/heads/3.0/vvl/acmp
[branch "3.0/nib-mains-configuration"]
remote = upstream
merge = refs/heads/3.0/nib-mains-configuration
[branch "3.0/revert-pr-316"]
remote = upstream
merge = refs/heads/3.0/revert-pr-316
[branch "3.0/fix-block-extension"]
remote = upstream
merge = refs/heads/3.0/fix-block-extension
[branch "3.0/clear-up-acmp"]
remote = upstream
merge = refs/heads/3.0/clear-up-acmp
[branch "3.0/power-manager-busywait"]
remote = upstream
merge = refs/heads/3.0/power-manager-busywait
[branch "3.0/fix-block"]
remote = upstream
merge = refs/heads/3.0/fix-block
[branch "3.0/improve-jenkins-tests"]
remote = upstream
merge = refs/heads/3.0/improve-jenkins-tests
[branch "3.0/vvl/test-ci-agent"]
remote = upstream
merge = refs/heads/3.0/vvl/test-ci-agent
[branch "3.0/add-nib-msg-type"]
remote = upstream
merge = refs/heads/3.0/add-nib-msg-type
[branch "3.0/unify-vdd-monitoring-input"]
remote = upstream
merge = refs/heads/3.0/unify-vdd-monitoring-input
[branch "3.0/ci-fix-jlink"]
remote = upstream
merge = refs/heads/3.0/ci-fix-jlink
[branch "3.0/CPP-1191-store-position-on-powerfail"]
remote = upstream
merge = refs/heads/3.0/CPP-1191-store-position-on-powerfail
[branch "3.0/Add-VSCode-manual"]
remote = upstream
merge = refs/heads/3.0/Add-VSCode-manual
[branch "3.0/CPP-1254-two-stage-shutdown"]
remote = upstream
merge = refs/heads/3.0/CPP-1254-two-stage-shutdown
[branch "3.0/ci-checkout-fix"]
remote = upstream
merge = refs/heads/3.0/ci-checkout-fix
[branch "3.0/ci-fixes"]
remote = upstream
merge = refs/heads/3.0/ci-fixes
[branch "3.0/vvl/vojtuv-experimentalni-master-smrt-vsem-bugum"]
remote = upstream
merge = refs/heads/3.0/vvl/vojtuv-experimentalni-master-smrt-vsem-bugum
[branch "3.0/unit-test-tuning"]
remote = upstream
merge = refs/heads/3.0/unit-test-tuning
[branch "3.0/remove-unused-files"]
remote = upstream
merge = refs/heads/3.0/remove-unused-files
[branch "vvl/standby-experiments"]
remote = upstream
merge = refs/heads/vvl/standby-experiments
[branch "3.0/ci-iar9321"]
remote = upstream
merge = refs/heads/3.0/ci-iar9321
[branch "3.0/vvl/trace-energy-manager"]
remote = upstream
merge = refs/heads/3.0/vvl/trace-energy-manager
[branch "fix-recalibration-request-message"]
remote = upstream
merge = refs/heads/fix-recalibration-request-message
[branch "VMa/fix-recalibration-request-message"]
remote = upstream
merge = refs/heads/VMa/fix-recalibration-request-message
[branch "set-vtor"]
remote = upstream
merge = refs/heads/set-vtor
[branch "jenkins-nightly-builds"]
remote = upstream
merge = refs/heads/jenkins-nightly-builds
[branch "prune-test-output"]
remote = upstream
merge = refs/heads/prune-test-output
[branch "3.0/bootloader-test"]
remote = upstream
merge = refs/heads/3.0/bootloader-test
[branch "3.0/update-testingtool-minimal"]
remote = upstream
merge = refs/heads/3.0/update-testingtool-minimal
[branch "3.0/integration-test-selector"]
remote = upstream
merge = refs/heads/3.0/integration-test-selector
[branch "3.0/boottrace-protocol"]
remote = upstream
merge = refs/heads/3.0/boottrace-protocol
[branch "3.0/securable-option-bytes"]
remote = upstream
merge = refs/heads/3.0/securable-option-bytes
[branch "3.0/CPP-1374-Fix-restricted-zone"]
remote = upstream
merge = refs/heads/3.0/CPP-1374-Fix-restricted-zone
[branch "3.0/CPP-1461-have-the-cpufreq-as-parameter-in-cyclecounter"]
remote = upstream
merge = refs/heads/3.0/CPP-1461-have-the-cpufreq-as-parameter-in-cyclecounter
[branch "3.0/port-rain-sensor"]
remote = upstream
merge = refs/heads/3.0/port-rain-sensor
[branch "3.0/initial-rain-sensor-port"]
remote = upstream
merge = refs/heads/3.0/initial-rain-sensor-port
[branch "3.0/add-switcher"]
remote = upstream
merge = refs/heads/3.0/add-switcher
[branch "3.0/rain-sensor-memento"]
remote = upstream
merge = refs/heads/3.0/rain-sensor-memento
[branch "3.0/update-test-strategy"]
remote = upstream
merge = refs/heads/3.0/update-test-strategy
[branch "3.0/fix-debug-mains"]
remote = upstream
merge = refs/heads/3.0/fix-debug-mains
[branch "4.0/update-test-strategy"]
remote = upstream
merge = refs/heads/4.0/update-test-strategy
[branch "4.0/fix-debug-mains"]
remote = upstream
merge = refs/heads/4.0/fix-debug-mains
[branch "4.0/boottrace-protocol"]
remote = upstream
merge = refs/heads/4.0/boottrace-protocol
[branch "3.0/TKa/segger-not-working"]
remote = upstream
merge = refs/heads/3.0/TKa/segger-not-working
[branch "3.1/master"]
remote = upstream
merge = refs/heads/3.1/master
[branch "3.1/switch-doxygen-to-196"]
remote = upstream
merge = refs/heads/3.1/switch-doxygen-to-196
[branch "3.1/fix-config-for-196"]
remote = upstream
merge = refs/heads/3.1/fix-config-for-196
[branch "test/3.1/master"]
remote = upstream
merge = refs/heads/test/3.1/master
[branch "3.1/build-doxygen-always"]
remote = upstream
merge = refs/heads/3.1/build-doxygen-always
[branch "3.0/update-drive-test"]
remote = upstream
merge = refs/heads/3.0/update-drive-test
[branch "3.0/unify-integration-test-constants"]
remote = upstream
merge = refs/heads/3.0/unify-integration-test-constants
[branch "3.0/remove-obsolete-tests"]
remote = upstream
merge = refs/heads/3.0/remove-obsolete-tests
[branch "3.0/remove-blinds-tests"]
remote = upstream
merge = refs/heads/3.0/remove-blinds-tests
I hope this will help you find fix for this issue. Thank you.
I think I encountered a similar crash to this:
POTENTIAL DEADLOCK:
Previous place where the lock was grabbed
goroutine 58 lock 0x140002b1c88
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:302 helpers.(*RefreshHelper).refreshCommitsWithLimit ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:301 helpers.(*RefreshHelper).refreshCommitsWithLimit ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:257 helpers.(*RefreshHelper).refreshCommitsAndCommitFiles ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:101 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:679 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:665 gocui.(*Gui).OnWorker.func1 ???
Have been trying to lock it again for more than 30s
goroutine 145 lock 0x140002b1c88
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:302 helpers.(*RefreshHelper).refreshCommitsWithLimit ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:301 helpers.(*RefreshHelper).refreshCommitsWithLimit ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:257 helpers.(*RefreshHelper).refreshCommitsAndCommitFiles ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:101 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:679 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:665 gocui.(*Gui).OnWorker.func1 ???
Here is what goroutine 58 doing now
goroutine 58 [semacquire]:
sync.runtime_Semacquire(0x3?)
runtime/sema.go:62 +0x2c
sync.(*WaitGroup).Wait(0x140002b0080)
sync/waitgroup.go:116 +0x78
github.com/jesseduffield/lazygit/pkg/commands/git_commands.(*CommitLoader).GetCommits(0x140003b46c0, {0x1, {0x0, 0x0}, 0x1, {0x10526168d, 0x4}, 0x0})
github.com/jesseduffield/lazygit/pkg/commands/git_commands/commit_loader.go:116 +0x3b4
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers.(*RefreshHelper).refreshCommitsWithLimit(0x1400009e340)
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:305 +0x264
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers.(*RefreshHelper).refreshCommitsAndCommitFiles(0x1400009e340)
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:257 +0x20
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers.(*RefreshHelper).Refresh.func2.1.1({0x0?, 0x0?})
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:101 +0x24
github.com/jesseduffield/gocui.(*Gui).onWorkerAux(0x0?, 0x0?, {0x10553c2b0?, 0x14000395960?})
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:678 +0x6c
github.com/jesseduffield/gocui.(*Gui).OnWorker.func1()
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:665 +0x34
created by github.com/jesseduffield/gocui.(*Gui).OnWorker
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:664 +0x9c
Other goroutines holding locks:
goroutine 146 lock 0x140002b1c70
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:415 helpers.(*RefreshHelper).refreshBranc
hes ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:414 helpers.(*RefreshHelper).refreshBranches ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:253 helpers.(*RefreshHelper).refreshReflogAndBranches ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:101 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:679 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:665 gocui.(*Gui).OnWorker.func1 ???
goroutine 26549 lock 0x140002b1c68
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:452 helpers.(*RefreshHelper).refreshFilesAndSubmodules ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:451 helpers.(*RefreshHelper).refreshFilesAndSubmodules ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:139 helpers.(*RefreshHelper).Refresh.func2.5 ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:101 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:679 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:665 gocui.(*Gui).OnWorker.func1 ???
goroutine 20733 lock 0x140002b1ca8
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/confirmation_helper.go:181 helpers.(*ConfirmationHelper).CreatePopupPanel ??? <<<<<
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/confirmation_helper.go:180 helpers.(*ConfirmationHelper).CreatePopupPanel ???
github.com/jesseduffield/lazygit/pkg/gui/gui.go:480 gui.NewGui.func1 ???
github.com/jesseduffield/lazygit/pkg/gui/popup/popup_handler.go:106 popup.(*PopupHandler).Confirm ???
github.com/jesseduffield/lazygit/pkg/gui/popup/popup_handler.go:94 popup.(*PopupHandler).ErrorMsg ???
github.com/jesseduffield/lazygit/pkg/gui/popup/popup_handler.go:94 popup.(*PopupHandler).ErrorMsg ???
github.com/jesseduffield/lazygit/pkg/gui/popup/popup_handler.go:80 popup.(*PopupHandler).Error ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:601 helpers.(*RefreshHelper).refreshRemotes ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:152 helpers.(*RefreshHelper).Refresh.func2.8 ???
github.com/jesseduffield/lazygit/pkg/gui/controllers/helpers/refresh_helper.go:101 helpers.(*RefreshHelper).Refresh.func2.1.1 ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:679 gocui.(*Gui).onWorkerAux ???
github.com/jesseduffield/gocui@v0.3.1-0.20230806095321-ac7b03108825/gui.go:665 gocui.(*Gui).OnWorker.func1 ???
though the error i see in lazygit is 2:23: unknown escape sequence (and 5 more errors)
i'm on mac, version from brew: commit=, build date=, build source=homebrew, version=0.40.2, os=darwin, arch=arm64, git version=2.39.2 (Apple Git-143)
the error happens on this repository only
the log seems to go into infinite loop before crashing, producing ~20k lines before it crashes
Describe the bug Upon start on existing repository lazygit opens but error is shown "35:2: illegal character U+002D '-'". Then it crashes.
To Reproduce Start lazygit in repository on Windows 10 using cmd.
Expected behavior A clear and concise description of what you expected to happen.
Screenshots![image](https://github.com/jesseduffield/lazygit/assets/7551269/2ba9e688-4725-4b5e-9634-e3a13983e1af)
Version info: commit=5e388e21c8ca6aa883dbcbe45c47f6fdd5116815, build date=2023-08-07T14:05:48Z, build source=binaryRelease, version=0.40.2, os=windows, arch=amd64, git version=2.41.0.windows.1
git version 2.41.0.windows.1
Additional context Cmd contents after crash:
Debug log