jessehouwing / azure-pipelines-tfvc-tasks

Azure Pipelines tasks for Team Foundation Version Control
https://marketplace.visualstudio.com/items?itemName=jessehouwing.jessehouwing-vsts-tfvc-tasks
MIT License
27 stars 18 forks source link

Build.SourceTfvcShelveset seems to be depricated by Microsoft!?... #69

Closed btremblaymtech closed 5 years ago

btremblaymtech commented 5 years ago

Hi, This weekend, Microsoft seems to have depricated the variable Build.SourceTfvcShelveset!! I guess this broke your addin which is very useful for us. The variable Build.SourceBranchName has the same value and still working. Is it possible for you to very / correct the probleme?

thanks

Benoit

jessehouwing commented 5 years ago

Argh. Since I also have users on tfs 2015 and 2017 I'll have to figure out how to correct this whole maintaining backwards compat.

On Mon, 10 Sep 2018, 17:12 btremblaymtech, notifications@github.com wrote:

Hi, This weekend, Microsoft seems to have depricated the variable Build.SourceTfvcShelveset!! I guess this broke your addin which is very useful for us. The variable Build.SourceBranchName has the same value and still working. Is it possible for you to very / correct the probleme?

thanks

Benoit

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jessehouwing/vsts-tfvc-tasks/issues/69, or mute the thread https://github.com/notifications/unsubscribe-auth/AD-uS7va4dzhtPuf7H580FoI3Z0-F1WAks5uZoFxgaJpZM4Whm3K .

jessehouwing commented 5 years ago

Sure looks like a regression, the docs still mention the variable:

Build.SourceTfvcShelveset | Defined if your repository is Team Foundation Version Control. If you are running a gated build or a shelveset build, this is set to the name of the shelveset you are building. Note: This variable yields a value that is invalid for build use in a build number format. https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=vsts

The code in the vsts-agent repo still seems to (try to ) populate it. Can you provide more information about the exact agent version and can you provide me a log of the build with the following two options enabled:

system.debug = true
agent.diagnostic = true
btremblaymtech commented 5 years ago

Hi, Thanks for investigated! :-)

Here is my log file. Hope this helps

Benoit logs_13038.zip