jessesquires / JSQMessagesViewController

An elegant messages UI library for iOS
https://www.jessesquires.com/blog/officially-deprecating-jsqmessagesviewcontroller/
Other
11.14k stars 2.82k forks source link

Tab bar offset bug after updating pod to 7.3.0 #1602

Closed Uki19 closed 8 years ago

Uki19 commented 8 years ago

After i updated pod to 7.3.0 i got bug with tab bar. I have tabbar application and when i push my chat view controller (JSQMessagesViewController), i set hidesBottomBarWhenPushed so it hides my app tabbar and text input field should be on bottom. This worked properly in 7.2.0 version. Now i get slight delay with tabbar disappearance so when i push my chat view controller it looks like this(image bellow) and after 1 second text input is dropped down where it should be:

img_3360

I've browsed some latest closed issues for 7.3.0 and i found this pull request #1588. This change produced this bug for me, as i already experienced this bug before and the reason behind it is when view is constrained to bottom layout guide instead of 0px to bottom of superview.

Is there a way to customize this constraint? I know i could hide/show tabbar in viewDidAppear/Disappear but that would make some complications in my case.

jessesquires commented 8 years ago

Thanks @Uki19 ! 😄

Sorry for this regression. If you remove the changes to viewWillLayoutSubviews does it affect the behavior?

Also, is your tabbar transparent?

Uki19 commented 8 years ago

@jessesquires No difference with viewWillLayoutSubviews. My tabbar is transparent (if you mean translucent) 😄 Tabbar actually disappears properly, just textfield view(or whatever view is on bottom in this scenario) has delay. I forgot to mention that i am using JSQMessagesViewController inside container view, but i've tried all fixes on both chat view controller and its container view controller. 146429675513694

jessesquires commented 8 years ago

fixed by #1623