jest-community / vscode-jest

The optimal flow for Jest based testing in VS Code
MIT License
2.83k stars 291 forks source link

[BUG] nvm not used and version not applied #1155

Open obrejla opened 3 months ago

obrejla commented 3 months ago

Describe the bug When my jest config and srcs are under directory with .nvmrc, then the proper version of the node is not used for running jest tests. It used just the default.

To Reproduce Have a project which uses nvm for managing node versions, have the "default" different from what is required by the test runner...try to run tests in vscode via your extension. The default node version is used, not the one specified by .nvmrc in the project directory.

Expected behavior Test runner embraces nvmrc and node version specified in it.

Environment (please complete the following information):

Prerequisite

Additional context

connectdotz commented 3 months ago

This extension will start a non-login/non-interactive shell to run the jestCommandLine, therefore, the location of your nvm setting matters. For example, in zsh, if you put the nvm config/loading logic in .zshrc, it will only work for the interactive shells (the terminals). You might need to consider moving the nvm logic to .zshenv or changing the jest.env to login-shell, for example.