hotfix for idn_to_ascii() using php7.4-intl

jethrocarr / namedmanager

AGPL web-based DNS management interface in PHP

349 stars 126 forks source link

Closed binsky08 closed 3 years ago

binsky08 commented 3 years ago

Up to php7.2-intl the default variant of idn_to_ascii() was INTL_IDNA_VARIANT_2003. From php7.4-intl the default variant is INTL_IDNA_VARIANT_UTS46. (see https://www.php.net/manual/de/function.idn-to-ascii.php and https://www.php.net/manual/de/migration72.deprecated.php)

This PR ensures that the old variant is still used, as the new one is no longer case sensitive, which is, however, required for some DNS entries.

fixes #92

jethrocarr commented 3 years ago

Awesome thanks for the fix @binsky08

binsky08 commented 3 years ago

No problem, I would be happy if you @jethrocarr could add the label "hacktoberfest-accepted" to this PR