Closed nonamef closed 2 months ago
Looks like I missed the defined vars in the deployment. Would be good if it was in the readme. https://github.com/jetstack/version-checker/blob/74cde3ce164e8ef2a988e86319e9957778dd2de6/deploy/charts/version-checker/templates/deployment.yaml#L134
{{- if .Values.docker.username }}
- name: VERSION_CHECKER_DOCKER_USERNAME
valueFrom:
secretKeyRef:
name: {{ $chartname }}
key: docker.username
{{- end }}
{{- if .Values.docker.password }}
- name: VERSION_CHECKER_DOCKER_PASSWORD
valueFrom:
secretKeyRef:
name: {{ $chartname }}
key: docker.password
{{- end }}
Currently if you want to add any username/password, it's done as a string. As the helm chart code is stored in a repository, anyone with access can see the credentials without issue. e.g
An enhancement would be to define the credentials as an environment variable so that secrets could be used to mask the credentials. e.g