search

jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more
https://eclipse.dev/jetty
Other
3.84k stars 1.91k forks source link

Provide --rm-module to remove existing module or remove jsp/jstl as default module in docker image #10224

Open jnehlmeier opened 1 year ago

jnehlmeier commented 1 year ago

Jetty version(s) Jetty 9.x is now at End of Community Support

Docker image 10.0.15 (probably just all images)

Enhancement Description

I am currently trying to migrate a custom built jetty docker image to the official one so I have to deal with less surprises like the recent introduction of quotes on parameters.

It seems like the official docker image adds JSP and JSTL support by default and I am wondering why you do that. Shouldn't downstream projects decide which features to enable? I don't use JSP/JSTL at all and would like to remove it. But it seems there is no --rm-module as the opposite of --add-module. So the only option I have is to figure out what the JSP/JSTL modules have added to jetty base and revert these modifications manually.

Any chance you would remove JSP/JSTL as default modules or provide a --rm-module parameter to do the cleanup work based on the description in *.mod file?

joakime commented 1 year ago

Just delete ${jetty.base}/start.d/jsp.ini and/or ${jetty.base}/start.d/jstl.ini

jnehlmeier commented 1 year ago

Yeah that is what I do now. Same for websocket which pulls in two implementations while new projects likely only need the javax version.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 weeks ago

This issue has been closed due to it having no activity.

sbordet commented 3 weeks ago

This still seems to be relevant.