jevan13 / pe

0 stars 0 forks source link

Phone number length allowed to be more than 20 digits long #10

Open jevan13 opened 1 week ago

jevan13 commented 1 week ago

Step to reproduce: edit 1 p/09472304723047203742037402934

Screenshot 2024-11-15 at 5.07.24 PM.png

nus-se-script commented 4 days ago

Team's Response

If the problem happens only in case of a deliberate sabotage (e.g., user entered a 30-digit telephone number), it will not be considered a bug (in our context).

The above was found in the CS2103 PE guide.

In addition, we changed this to low as we feel that it is almost impossible for someone to "incorrectly" type such a long phone number, as it requires the user to explicitly type out a lot more numbers than intended. To be considered a feature flaw, "Some functionality missing from a feature delivered in the current version in a way that the feature becomes less useful to the intended target user for normal usage." However, this is not normal usage, and is deliberate sabotage, as elaborated on in the extract from the CS2103 PE guide.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Hi, maybe the example I used was too extreme, but my point as explained before was:


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Given that this application has to handle a large amount of data, typing in all the informations (name, NRIC, email, phone number, etc.) can likely cause this issue to happen. It would be nice if the application could guard against it to reduce inconvenience to users.