search

jflamy / owlcms4

Olympic Weightlifting Competition Management System
https://owlcms.github.io/owlcms4/#/index
Other
67 stars 22 forks source link

Update USAW results output #527

Closed scottgonzalez closed 2 years ago

scottgonzalez commented 2 years ago

Is your feature request related to a problem? Please describe. USAW has switched to using the BARS system for submitting results. The current export does not match the format used by BARS.

Describe the solution you'd like Update the USAW results format to use https://www.teamusa.org/-/media/USA_Weightlifting/Documents/Membership/2020/USAWResultsTemplate.xlsx

jflamy commented 2 years ago

I had sent a BARS format to the mailing list for validation but no-one replied. See files enclosed.

So USAWResultsTemplate.xls USAW-AgeGroups.xlsx

jflamy commented 2 years ago

The files go under local/templates/protocol and local/agegroups respectively. You need to load the age groups file and reallocate the athletes. I could in theory load add a _en_US locale to the file and make it load automatically on first run, but cloud providers tend to run under that locale so I have no surefire way of guessing.

jflamy commented 2 years ago

If the files work out I will add them to the distribution.

scottgonzalez commented 2 years ago

I'll see if I can get this tested with BARS.

I did notice that the weight classes are not correct for at least one of the age groups. I'll go through and check all of them later and provided an updated file.

I also noticed that the results spreadsheet has a broken value for the Age Category column for master's women. This is because the Results sheet uses W35 while the Validation sheet uses F35, so the VLOOKUP fails. I assume this should be an update in the age groups spreadsheet to change the codes to use F?

jflamy commented 2 years ago

I recently changed the Masters groups to have W as in the Masters's rule book. So yes, try changing the F for W on the validation tab.

jflamy commented 2 years ago

(for clarity, it should be W35 throughout). F35 is a relic.

scottgonzalez commented 2 years ago

I've updated both files locally and generated a new results sheet. I just emailed that to Pedro Meloni, USAW's Director of Events, for testing.

Toolazy2work commented 2 years ago
  1. I just came here to make the same request, so thank you @scottgonzalez for already making it and for @jflamy for already addressing it!
  2. I just learned there is a mailing list!
jflamy commented 2 years ago

Mailing list is owlcms on Google Groups

jflamy commented 2 years ago

I've updated both files locally and generated a new results sheet. I just emailed that to Pedro Meloni, USAW's Director of Events, for testing.

Scott, care to post the updated files here ?

scottgonzalez commented 2 years ago

Here are the updated files. I still haven't been able to confirm that the generated results are accepted by BARS. I'll keep trying to get access. At least the age groups should be correct.

USAWResultsTemplate.xls

USAW-AgeGroups.xlsx

jflamy commented 2 years ago

I have fixed missing bodyweight categories to the agegroups file (first tab) and added instructions on how to remove formulas from the owlcms-generated output. Also fixed the excel format for numbers. Will be in the stable 34.4.0 release. In the mean time, here are the updated files. USAW-AgeGroups.xlsx USAWResultsTemplate.xls

jflamy commented 2 years ago

Note that the age groups file has the Open categories enabled by default. So a U13 36kg will show up in the open category as well. Maybe the open categories should not be enabled?

Toolazy2work commented 2 years ago

I think if the output can match the “best fit” category. Example, some people will match 3 or 4 categories. If in these categories, they match a “best fit” in the template, they can be assigned that category in the output.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Jean-François Lamy @.> Sent: Tuesday, November 1, 2022 12:45:39 PM To: jflamy/owlcms4 @.> Cc: Nick @.>; Comment @.> Subject: Re: [jflamy/owlcms4] Update USAW results output (Issue #527)

Note that the age groups file has the Open categories enabled by default. So a U13 36kg will show up in the open category as well. Maybe the open categories should not be enabled?

— Reply to this email directly, view it on GitHubhttps://github.com/jflamy/owlcms4/issues/527#issuecomment-1298818104, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARGANFO4AHT4A2DL5NHIWTWGFCLHANCNFSM6AAAAAAQ34NY3Y. You are receiving this because you commented.Message ID: @.***>

jflamy commented 2 years ago

That is actually the case for the results - the most specific category will be used. But with respect to the actual meet, with the age group file as it currently stands a 13 year old will be shown as eligible for the Open medals. Not sure that is what is intended for kids this young -- looks odd when looking at the registration page.

Toolazy2work commented 2 years ago

I thought that U13 ARE eligible for open medals.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Jean-François Lamy @.> Sent: Tuesday, November 1, 2022 2:18:36 PM To: jflamy/owlcms4 @.> Cc: Nick @.>; Comment @.> Subject: Re: [jflamy/owlcms4] Update USAW results output (Issue #527)

That is actually the case for the results - the most specific category will be used. But with respect to the actual meet, with the age group file as it currently stands a 13 year old will be shown as eligible for the Open medals. Not sure that is what is intended -- looks odd when looking at the registration page.

— Reply to this email directly, view it on GitHubhttps://github.com/jflamy/owlcms4/issues/527#issuecomment-1298927889, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARGANF43ZZRS6CKHKVDVXTWGFNHZANCNFSM6AAAAAAQ34NY3Y. You are receiving this because you commented.Message ID: @.***>

jflamy commented 2 years ago

Then so be it, that's what's in the file. Included in 34.4.0-rc02 will also be in stable release.

Toolazy2work commented 2 years ago

Jean-François, you’re amazing. Thank you for giving the community an incredible piece of software to bring our sport to modern times!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Jean-François Lamy @.> Sent: Tuesday, November 1, 2022 3:41:14 PM To: jflamy/owlcms4 @.> Cc: Nick @.>; Comment @.> Subject: Re: [jflamy/owlcms4] Update USAW results output (Issue #527)

Then so be it, that's what's in the file. Included in 34.4.0-rc02 will also be in stable release.

— Reply to this email directly, view it on GitHubhttps://github.com/jflamy/owlcms4/issues/527#issuecomment-1299023764, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AARGANDTQPDMKZRITTEQIRDWGFW5VANCNFSM6AAAAAAQ34NY3Y. You are receiving this because you commented.Message ID: @.***>