jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Refactor the `npx` replacement #236

Closed lishaduck closed 2 months ago

lishaduck commented 2 months ago

There wasn't really consensus on the original issue, but I wanted to write some code, so 🤷‍♂️ I improved the docs at least :) For reference, the diff is -82 +82 lines, so it's literally a net neutral w/regard to maintainability. It primarily does so by reusing existing code for emulating npx for elm-format instead of using another (hacky) handrolled solution I introduced in #197 (as a nice side effect, we test that the CLI works without --compiler in the unit tests again).

Closes #224.