jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

chore(deps): bump stil4m/elm-syntax from 7.3.2 to 7.3.5 in /new-package/review-config-templates/2.3.0 #240

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Bumps stil4m/elm-syntax from 7.3.2 to 7.3.5.

Changelog

Sourced from stil4m/elm-syntax's changelog.

[7.3.5] - 2024-08-30

  • The parser is stricter in a few cases where code that was incorrect (according to the Elm compiler) was successfully parsed: tuples with more than 3 elements, and record access on most things
  • Parsing is about 6 times faster than the previous release!

[7.3.4] - 2024-07-26

Parsing is faster by ~90%. A big thank you to @​lue-bird for finding and introducing a huge amount of performance improvements.

[7.3.3] - 2024-07-18

Parser rewrite using a Pratt parser

This patch is a major rewrite of the parser, which now uses a Pratt parser under the hood (see https://martin.janiczek.cz/2023/07/03/demystifying-pratt-parsers.html for an explanation).

Prior to this version, the source code was parsed and then post-processed - to rebalance the tree around operator precedence and to attach documentation comments. This is now all done in a single pass, which improves performance by about 15%.

This rewrite includes a few additional changes:

  • a few bug fixes where code that was incorrect Elm code (according to the Elm compiler) was successfully parsed
  • better performance, parsing should now be faster
  • support for multiline strings in patterns

A big thank you to @​jiegillet and @​janiczek for their help.

Deprecation of Elm.Writer

The Elm.Writer module has never been very good and tended to, and we do not desire maintaining it, and it will therefore likely be removed in a future major version. We highly recommend using the-sett/elm-syntax-dsl instead, which is much better anyways.

Commits
  • 94e3795 7.3.5
  • f5a87f0 Change version
  • 9135f6b Make find-regressions scripts better support glob arguments
  • 6ee4865 Fix Simplify errors
  • 43ca516 Sort records
  • 120fa1e explain Char.Extra.isUtf16Surrogate
  • 22a4592 add test for range of comments that include 2-part utf-16 character
  • 15f37cb correct ranges that include 2-part utf-16 chars (making the parser slightly s...
  • 01a147e remove ParserWithComments.until* helpers because they aren't faster
  • ee75e57 use maybeLayoutUntilIgnored in a few more places
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
lishaduck commented 2 months ago

CI's breaking for everything b/c everything needs 7.3.5 (not this PR's fault).

Finally got a chance to check this out, new elm-syntax broke tests again.

And again, in 7.3.5 😢

Originally posted by @lishaduck in https://github.com/jfmengels/node-elm-review/issues/176#issuecomment-2325358713

dependabot[bot] commented 2 months ago

Superseded by #249.

lishaduck commented 2 months ago

Should be good to merge (SemVer minor), but we probably ought to wait until CI's fixed (https://github.com/jfmengels/node-elm-review/issues/176#issuecomment-2325358713).