search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Better TS #302

Closed lishaduck closed 2 weeks ago

lishaduck commented 2 weeks ago

Follow up to #301.

Works on TSESlint-based safety. Probably broke some stuff with error handling.

Please review closely,[^1] some of these changes might be better served with ignores. Then again, ignores are evil, so... I just fixed them all and hoped for the best.

Oh, and I added more JSDocs for literally everything! Yay!

[^1]: EDIT: 🤣

socket-security[bot] commented 2 weeks ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@package-json/types@0.0.11 None 0 17.8 kB kwaa

View full report↗︎

lishaduck commented 2 weeks ago

@jfmengels, ping pong 🏓 :)

jfmengels commented 2 weeks ago

Great work!

Btw, thank you for your nice commit etiquette for your PRs. It's easy to review each commit (except maybe for 3965c34b3c9339a6c77cc6654e69e375e22684ad :stuck_out_tongue: , although it was not that bad in practice)