search

jfmengels / node-elm-review

CLI for elm-review
https://package.elm-lang.org/packages/jfmengels/elm-review/latest/
BSD 3-Clause "New" or "Revised" License
48 stars 25 forks source link

Replace GITHUB_AUTH by AUTH_GITHUB #309

Closed jfmengels closed 1 week ago

jfmengels commented 1 week ago

Environment variables in GitHub can't start with "GITHUB_".

I created an environment for GitHub Actions with a AUTH_GITHUB, which will be used for tests that use --template. Hopefully this will help prevent rate limits :crossed_fingers:

jfmengels commented 1 week ago

I don't know if it worked, I guess we'll see as we do more changes :man_shrugging:

lishaduck commented 1 week ago

It worth considering that now it'll directly count against you (i.e., if say I wrote some code to spam the api, you'd be the one flagged for abuse), perhaps you should use secrets.GITHUB_TOKEN (built-in token, granular permissions), which would count against the triggerer.