Open mwmadsen67 opened 4 years ago
The docs are looking pretty nice Jack, nice job on the formatting.
Schema: Looking good overall, just a few notes. I believe you're missing a stock price on your assets table? Or is that intentional? I should warn you that if you plan on relying on calls to a separate stock API for pricing that you will run out of the free requests very quickly. My advice would be to use any outside stock API calls as sparingly as possible, and store any and all info in your database. Also in holdings, you probably dont want the [owner_id and asset_id] combo to be unique, since that would only allow you to buy an asset once.
State-Shape: State shape looks excellent, It is missing a slice of state for watches though. I'm also wondering what the motivation is for making the holdings slice of state an array.
MVP list: looks good
Overall its a great start, let me know in this thread if you have questions.
I know we talked today but I'm going to leave another comment just to keep a record of it.
Backend Routes: You likely don't need to nest assets under users to get the users assets, since you always have access to current user. Everything else is good. You should also think how you would store asset info from your external api. Unless you make the requests from your backend, you will likely need a way of post assets from your frontend so that you could store info without making too many requests to external apis.
Frontend Routes: Everything looks good.
Wiki Page Home
Database Schema
back_ticked
back_ticked
back_ticked
Sample State
```javascript...```
). This will display the state as a code block instead of a giant line of textentities
session
errors
(here or inui
)ui
(if needed)comments
inside ofposts
MVP List
Backend Routes
snake_case
GET likes
api endpoint because that info comes through the post showFrontend Routes
camelCase
inline coding text
(backticks)