search

jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
254 stars 439 forks source link

[xray] add defaultRetentionDaysForIndexedRepo support #1833

Closed gregoryboue closed 1 month ago

gregoryboue commented 10 months ago

PR Checklist

What this PR does / why we need it:

Currently the Xray indexing default retention period can be defined in Xray System yaml with server.repo.defaultRetentionDaysForIndexedRepo settings.

If we want to configure this settings, we have to override xray system yaml (see systemYamlOverride), so it would be great to be able to configure this setting via a value in the chart's values.yaml file.

Which issue this PR fixes : fixes #1832

github-actions[bot] commented 10 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

gregoryboue commented 10 months ago

I have read the CLA Document and I hereby sign the CLA

gregoryboue commented 10 months ago

Is there anyone to review ?

rahulsadanandan commented 10 months ago

@gregoryboue Thanks for the PR. We will include this change in one of the upcoming releases.

gregoryboue commented 9 months ago

@gregoryboue Thanks for the PR. We will include this change in one of the upcoming releases.

Hi, do you have any information about the release date ?

gregoryboue commented 9 months ago

@rahulsadanandan , is this PR will be merged ?

gregoryboue commented 8 months ago

@rahulsadanandan any news ?

rahulsadanandan commented 8 months ago

@gregoryboue

We're exploring the concept of structured system YAML as part of another PR (https://github.com/jfrog/charts/pull/1842). This method enables us to modify individual system YAML parameters without the need to supply the entire system YAML block.

gregoryboue commented 8 months ago

@rahulsadanandan Thanks for the answer, it would be a very useful feature for us, i will waiting for it.

The ETA is for Q1 2024, do you have any precision about the month ?

rahulsadanandan commented 1 month ago

@gregoryboue Recently have merged a feature (https://github.com/jfrog/charts/pull/1842) that allows overriding the system YAML with the extraSystemYaml section. The entries specified under ‘xray.extraSystemYaml’ will be merged with files/system.yaml to generate the final system.yaml. This change is available from Xray version 103.95.x onwards.