jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
254 stars 439 forks source link

[xray] Adding structured system yaml to allow for individual key/value overrides #1842

Closed nxf5025 closed 2 months ago

nxf5025 commented 9 months ago

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it:

Allows users to add/overwrite parts of the textual representation of the system.yaml after template evaluation. This allows users to provide individual overrides for the default system.yaml without needing to copy and paste the whole config.

For example:

To add the configuration talked about in this article it's as easy adding it to the structuredSystemYaml:

xray:
  structuredSystemYaml:
    indexer:
      compress:
        RationLimit: 500

This would result in something like the following when fully rendered:

  system.yaml: |
    configVersion: 1
    contextualAnalysis:
      image: jfrog/xray-jas-contextual-analysis
      registry: releases-docker.jfrog.io
    exposures:
      container:
        image: jfrog/xray-jas-exposures
        registry: releases-docker.jfrog.io
    indexer:
      compress:
        RationLimit: 2000
    router:
      serviceRegistry:
        insecure: false
    shared:
      database:
        driver: org.postgresql.Driver
        type: postgresql
      jfrogUrl: http://artifactory.artifactory.svc.cluster.local:8082
      logging:
        consoleLog:
          enabled: true

Special notes for your reviewer: Inspiration is from the Mimir Helm chart - https://github.com/grafana/mimir/pull/2100

If this gets accepted I will also be opening a similar PR for the Artifactory chart

github-actions[bot] commented 9 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

nxf5025 commented 9 months ago

I have read the CLA Document and I hereby sign the CLA

chukka commented 9 months ago

@nxf5025 Thanks for the PR ! we would like to review this internally and come back next week . I hope this is much needed feature every one wants to try :)

cc @eldada @rahulsadanandan

chukka commented 9 months ago

Update : we are planning to take this feature in coming weeks, if there are any changes required to this PR , we will let you know.

nxf5025 commented 9 months ago

@chukka Awesome sounds good. As promised I have also opened the Artifactory PR with the same changes - https://github.com/jfrog/charts/pull/1848

chukka commented 8 months ago

Update : we are internally evaluating refactoring systemYaml in values.yaml and would like to take this PR as part of it in next quarter , Thanks for your patience !

gregoryboue commented 7 months ago

@chukka any news on the ETA ?

Logeshwarsn commented 7 months ago

@gregoryboue We are planning to take this feature in this quarter. And we will update you on the release date soon.

gregoryboue commented 6 months ago

@Logeshwarsn the end of the quarter is coming, any news on this feature ?

gregoryboue commented 5 months ago

@chukka @Logeshwarsn do you have any release date of this feature ?

megha1906 commented 5 months ago

@gregoryboue Due to other priorities, there has been a delay. We are now including this feature in the 3.95.x release, scheduled for May.

gregoryboue commented 3 months ago

@gregoryboue Due to other priorities, there has been a delay. We are now including this feature in the 3.95.x release, scheduled for May.

Hi, we are in may and the 3.96 has been released but this feature is not available, is it possible to have an ETA ?