search

jfrog / cocoapods-art

CocoaPods Plugin to work against Artifactory Repository
Apache License 2.0
58 stars 28 forks source link

Cocoapods v1.8.0 fix #36

Closed TripwireNL closed 5 years ago

TripwireNL commented 5 years ago
lampapos commented 5 years ago

@feldan @eyalbe4 take a look, please

p-i- commented 5 years ago

Please someone merge! We're bumping into https://github.com/jfrog/cocoapods-art/issues/33

matheusalano commented 5 years ago

Please merge this. I can't use Cocoapods v1.8.1

mschinis commented 5 years ago

This is blocking me from using cocoapods v1.8.1 also

eyalbe4 commented 5 years ago

We will review and release this one soon. Thank you @Tripwire999!

mahesh-shiva commented 5 years ago

This is a blocker for me too. Please merge.

eyalbe4 commented 5 years ago

@Tripwire999, Thank you for creating this PR! Can you please join our contributors community by signing JFrog's CLA so that we can merge your code?

TripwireNL commented 5 years ago

@eyalbe4 I checked the document you send through the link but i'm not interested in joining the JFrog contributers community especially if it requires me signing a legal contract.

eyalbe4 commented 5 years ago

@Tripwire999, We are not allowed to accept code contributions without having the contributor sign the CLA.

p-i- commented 5 years ago

yeowzers Strangulation by red-tape! @eyalbe4 How about if @Tripwire999 says "I hereby donate this code to the universe." Then you would be able to create your own identical branch and merge that. i.e. YOU become the contributor (and @Tripwire999 contributes to YOUR contribution, not to cocoapods-art repo directly). @Tripwire999 would you be okay with this...?

TripwireNL commented 5 years ago

@p-i- Sure :) I don't mind! But I won't sign a contract for a few lines of code I added.

"I hereby donate this code to the universe."

torfinnberset commented 5 years ago

@Tripwire999 thanks for your donating your code! I took and created #37, as we need this to be fixed for our project

TripwireNL commented 5 years ago

@torfinnberset Cool :)