jfrog / cocoapods-art

CocoaPods Plugin to work against Artifactory Repository
Apache License 2.0
58 stars 28 forks source link

cordova-ios Pod Does Not Install Using cocoapods-art Plugin #63

Open agrosskurth opened 1 year ago

agrosskurth commented 1 year ago

We are using cocoapods-art plugin (v1.1.0) for cocoa pods to install pods from remote repository in Artifactory.

Installation of all pods on the MacOs,

[ ""pod install" or "pod install --clean-install"]

is successful from the remote repo, except 'Cordova', which fails due to the following error:

[!] Error installing Cordova

[!] /usr/bin/curl -f -L -o /var/folders/mg/5d98rks136q_ds_pdsm8swbh0000gn/T/d20230419-14312-1kgqjs6/file.tgz https://SOTIARTIFACTORYURL/artifactory/api/pods/CocoaPodsSpecs/pod/git/apache/cordova-ios/rel/6.2.0 --create-dirs --netrc-optional --retry 2 -A 'CocoaPods/1.8.4 cocoapods-downloader/1.5.1' --ssl-no-revoke

In Artifactory, the request log shows an unencoded request when using the plugin, but if you encode it with cURL the download works: 2023-05-04T15:01:03.915Z|2deec6eae676b487|10.1.0.95|anonymous|GET|/api/pods/CocoaPodsSpecs/pod/git/apache/cordova-ios/rel/6.2.0|404|-1|0|1|'CocoaPods/1.8.4 cocoapods-downloader/1.5.1'

2023-05-04T15:03:11.610Z|e8c1d7610d626d96|10.1.0.95|anonymous|GET|/api/pods/CocoaPodsSpecs/pod/git/apache/cordova-ios/rel%2f6.2.0|200|-1|1130793|877|curl/7.87.0

To fix this behavior, the cocoapods-art plugin would need to be updated to allow for encoding the URLs of package requests.