Closed georgeskill closed 4 months ago
CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.
I have read the CLA Document and I hereby sign the CLA
You can retrigger this bot by commenting recheck in this Pull Request
I have read the CLA Document and I hereby sign the CLA
recheck
recheck
recheck
The API request payload needs to use this new config value. See https://github.com/jfrog/vault-plugin-secrets-artifactory/blob/master/artifactory.go#L149
Can you elaborate please? I am setting the request's ForceRevocable value to the config's value if it's not null.
@georgeskill You're right, you did! I missed it during review.
@georgeskill You're right, you did! I missed it during review.
Thanks for approving. How can I get the CLA Assistant action to pass? Am I missing a step to get it to pass?
@georgeskill You are good to go with CLA. The GitHub action is not very smart 😄 . I have an urgent task to take care first today so I'll merge this tomorrow.
@georgeskill If you wish to try to sign CLA again, please include only the CLA message. I think the last time you also included the 'rechecking' and that confused the GitHub Action.
I have read the CLA Document and I hereby sign the CLA
recheck
@georgeskill Don't worry about CLA GitHub Action. You clearly have signed it 😄
Hello. I went ahead and added the
force_revocable
parameter as an optional parameter. By default,use_expiring_tokens
will still setforce_revocable
totrue
, unless it is explicitly given. This should solve my issue at #174. My access tokens metadata indicated they were not revocable, but also had a value inexpires_in
."I have read the CLA Document and I hereby sign the CLA"