jfrog / vault-plugin-secrets-artifactory

HashiCorp Vault Secrets Plugin for Artifactory
https://jfrog.com
Apache License 2.0
39 stars 20 forks source link

feat: add force revocable parameter to token endpoints #175

Closed georgeskill closed 4 months ago

georgeskill commented 4 months ago

Hello. I went ahead and added the force_revocable parameter as an optional parameter. By default, use_expiring_tokens will still set force_revocable to true, unless it is explicitly given. This should solve my issue at #174. My access tokens metadata indicated they were not revocable, but also had a value in expires_in.

"I have read the CLA Document and I hereby sign the CLA"

github-actions[bot] commented 4 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

georgeskill commented 4 months ago

I have read the CLA Document and I hereby sign the CLA

gr-david-snowdon commented 4 months ago

recheck

georgeskill commented 4 months ago

recheck

alexhung commented 4 months ago

recheck

georgeskill commented 4 months ago

The API request payload needs to use this new config value. See https://github.com/jfrog/vault-plugin-secrets-artifactory/blob/master/artifactory.go#L149

Can you elaborate please? I am setting the request's ForceRevocable value to the config's value if it's not null.

alexhung commented 4 months ago

@georgeskill You're right, you did! I missed it during review.

georgeskill commented 4 months ago

@georgeskill You're right, you did! I missed it during review.

Thanks for approving. How can I get the CLA Assistant action to pass? Am I missing a step to get it to pass?

alexhung commented 4 months ago

@georgeskill You are good to go with CLA. The GitHub action is not very smart 😄 . I have an urgent task to take care first today so I'll merge this tomorrow.

alexhung commented 4 months ago

@georgeskill If you wish to try to sign CLA again, please include only the CLA message. I think the last time you also included the 'rechecking' and that confused the GitHub Action.

georgeskill commented 4 months ago

I have read the CLA Document and I hereby sign the CLA

georgeskill commented 4 months ago

recheck

alexhung commented 4 months ago

@georgeskill Don't worry about CLA GitHub Action. You clearly have signed it 😄