search

jglick / sezpoz

SezPoz: lightweight, annotation-based service loader
29 stars 11 forks source link

Handle case of hudson.Extension doesn't already exist for Eclipse. #5

Closed hughperkins closed 8 years ago

hughperkins commented 11 years ago

re: only catch IOException when using Eclipse filer:

re: apply message to each associated item

re: you didn't file a pull request

Note, I've also purged a META-INF/services file, which I think is now obsolete? and causes a build error on eclipse ("IndexerFactory not found")

buildhive commented 11 years ago

Jesse Glick » sezpoz #3 SUCCESS This pull request looks good (what's this?)

dscho commented 11 years ago

@hughperkins did you know that you can rewrite your branch, force-push, and this pull request will be updated automatically? There is no need to keep the original commit's undesired changes in the history...

jglick commented 11 years ago

Use rebase if you like but I am just as happy with follow-up commits. GitHub just shows the aggregate diff in a pull request anyway, so there is no real reason to use destructive commands.

Have not gotten a chance to review this yet, sorry, but it is on my radar.

dscho commented 10 years ago

@jglick the reason for a rebase is not so much that the diff GitHub shows looks better: as you pointed out, it does not. The reason is that the commit history is much easier to follow. Very important if you want to fix bugs that might not be bugs at all (it is very confusing to see a bad change and mull over it only to see at a later stage that the bad change was indeed bad, and that you cannot see the real change introduced by a pull request easily).

jglick commented 10 years ago

@dscho I just think this is something that should be handled by the viewer, not the committer. If a Git history display tool cannot show a logical pull request in collapsed form, then that is the fault of the tool. The history itself is fine. Anyway this is a tangent.

hughperkins commented 8 years ago

Not sure what is the state of this pull, but it's really old, and I'm pretty sure I'm not going to have time to address it further :-) => closing