jgromes / RadioLib

Universal wireless communication library for embedded devices
https://jgromes.github.io/RadioLib/
MIT License
1.47k stars 369 forks source link

LLCC68 support #310

Closed xixixihaha closed 3 years ago

xixixihaha commented 3 years ago

the new LLCC68 based Lora Module is out, is it possible to add the support in the coming release?

thx

IMPORTANT: Check the wiki Before submitting new issue, please check the Wiki and the API documentation. You might find a solution to your issue there.

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

jgromes commented 3 years ago

Briefly going through the datasheet, I didn't see any significant difference between SX126x and LLCC68, so the current SX126x classes should work. Could you try it, as I don't have the LLCC68 module?

xixixihaha commented 3 years ago

Thanks so much. I've verified it with SX1268 code. It worked like a charm.

jgromes commented 3 years ago

Thanks for letting me know, I added LLCC68 as alias for SX1268, so you can use LLCC68 as any other module class:

LLCC68 radio = new Module(1, 2, 3);